Bug 368721 - Sobel filter does not work
Summary: Sobel filter does not work
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Filters (show other bugs)
Version: 3.0.1
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL: https://www.youtube.com/watch?v=0ukWa...
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-13 00:21 UTC by Luis Payano
Modified: 2016-09-27 10:27 UTC (History)
1 user (show)

See Also:
Latest Commit: http://commits.kde.org/krita/045e917f657fd3c03931e07a3f40b11e23921fdd
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Luis Payano 2016-09-13 00:21:47 UTC 
Sobel filter is not working at all.

Video demonstration:

https://www.youtube.com/watch?v=0ukWaka0aJo&list=PLPbpshXgNLr-PRRnk9onOeb6NbEyJVy3N&index=4

Reproducible: Always

Steps to Reproduce:
1.Open document.
2.Draw lines on new layer.
3.Use sobel filter.

Actual Results:  
Sobel filter does not extract edges from the image, it only pads transparent areas with black.

Expected Results:  
Extract edges with or without filling transparency.

Windows 7,  Krita 3.0.1
Comment 1 Halla Rempt 2016-09-15 09:12:48 UTC 
Hi,

Thanks for your report. For me, the sobel filter seems to work okayish on non-transparent images with only one layer, though often it will forget to filter a block of pixels as well. It's one of our oldest filters...
Comment 2 Halla Rempt 2016-09-15 11:44:47 UTC 
Git commit 390015d9b5d80302cc8b2fb24ab4a6beb60ab866 by Boudewijn Rempt.
Committed on 15/09/2016 at 11:44.
Pushed by rempt into branch 'master'.
Related: bug 0, bug 0

M  +9    -38   plugins/filters/sobelfilter/kis_sobel_filter.cpp

http://commits.kde.org/krita/390015d9b5d80302cc8b2fb24ab4a6beb60ab866
Comment 3 Halla Rempt 2016-09-27 10:09:27 UTC 
Git commit dead7d2686147a4de06dd926ee1a16f0b608e50e by Boudewijn Rempt.
Committed on 27/09/2016 at 10:01.
Pushed by rempt into branch 'krita/3.0.1'.
Related: bug 0, bug 0

M  +9    -38   plugins/filters/sobelfilter/kis_sobel_filter.cpp

http://commits.kde.org/krita/dead7d2686147a4de06dd926ee1a16f0b608e50e
Comment 4 Halla Rempt 2016-09-27 10:27:04 UTC 
Git commit 045e917f657fd3c03931e07a3f40b11e23921fdd by Boudewijn Rempt.
Committed on 27/09/2016 at 10:07.
Pushed by rempt into branch 'krita/3.0.1'.
Related: bug 0, bug 0

M  +1    -1    plugins/filters/sobelfilter/kis_sobel_filter.cpp
M  +1    -1    plugins/filters/sobelfilter/kis_sobel_filter.h

http://commits.kde.org/krita/045e917f657fd3c03931e07a3f40b11e23921fdd