Bug 368661 - Regression: Cannot switch components in global keyboard shortcuts configuration
Summary: Regression: Cannot switch components in global keyboard shortcuts configuration
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_keys (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR major
Target Milestone: ---
Assignee: Michael Jansen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-11 20:57 UTC by Nicolas Dietrich
Modified: 2016-09-27 09:56 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Dietrich 2016-09-11 20:57:44 UTC
As of current Plasma git (version says 5.7.90) from neon/unstable, I cannot switch between components in the global keyboard shortcuts configuration module.

Reproducible: Always

Steps to Reproduce:
1. Open systemsettings -> shortcuts -> global shortcuts

"Audio volume" is selected, the respective shortcuts shown.

2. Click on any other component (e.g. kaccess, KWin, ...)

Actual Results:  
Nothing changes - the "audio volume" shortcuts are still shown.

Expected Results:  
Change to the shortcuts of the selected components.

Additionally, double clicking on a component label in the component list allows that label to be renamed, which is pretty awkward. Might be a separate bug, or related, in anycase strange.
Comment 1 João Bóia 2016-09-18 02:57:53 UTC
I also have this bug.

Arch Linux, Plasma 5.7.95
Comment 2 Wolfgang Bauer 2016-09-27 09:11:28 UTC
I can reproduce this when activating "Double-click to open files/folders" in the mouse settings.
Can you confirm that you did this?

This should fix it then:
https://phabricator.kde.org/D2865
Comment 3 Nicolas Dietrich 2016-09-27 09:35:39 UTC
> I can reproduce this when activating "Double-click to open files/folders" in the mouse settings. Can you confirm that you did this?

Yes. Indeed, switching to single-click to open files/folders makes the issue disappear.
Comment 4 David Edmundson 2016-09-27 09:56:39 UTC
Git commit 0797a16b9b113762fe6504c0214095ba21ee5647 by David Edmundson.
Committed on 27/09/2016 at 09:56.
Pushed by davidedmundson into branch 'Plasma/5.8'.

Change component shown on selection changes

Summary:
::activated depends on the mouse click behaviour - as double click
starts a rename this led to the global shortcuts KCM being unusable with
double click set.

This patch follows the selection chaging - which is more semantically
correct as we're not really activating an option in the left hand
sidebar, merely selecting it to show the correct sub-options.

It fixes keys up/down changing selection but also allows double click
mouse settings to work.

Test Plan:
Ran.
clicked once, got the correct sub-options.

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D2865

M  +7    -7    kcms/keys/kglobalshortcutseditor.cpp

http://commits.kde.org/plasma-desktop/0797a16b9b113762fe6504c0214095ba21ee5647