Bug 368624 - build-image.sh from packaging/linux/appimage/ requires mesa-libGLU-devel
Summary: build-image.sh from packaging/linux/appimage/ requires mesa-libGLU-devel
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (other bugs)
Version First Reported In: 3.0.1
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-11 19:22 UTC by beuc
Modified: 2016-09-12 11:27 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
fix (1.12 KB, patch)
2016-09-11 19:23 UTC, beuc
Details

Note You need to log in before you can comment on or make changes to this bug.
Description beuc 2016-09-11 19:22:51 UTC
build-deps.sh seems to be missing mesa-libGLU-devel

<boud> in any case, appimages shouldn't package mesa/glu/gl libs, afaik
<Beuc> Currently they ship it :) I had to install mesa-libGLU-devel because build-image.sh looks for it and fails when not present
<boud> weird
<Beuc> I'm using the scripts from krita/3.0.1 (or master, they are the same)
<Wolthera_laptop> hm... here 3.0.1 has libglu but no libmesa
<Beuc> yeah just libEGL and libGLU actually
<Wolthera_laptop> I also ave a libglapi here...
<Wolthera_laptop> and lib-xcb-glx, but no idea if that's relevant?
<Wolthera_laptop> boud: I think we carry them because otherwise it might be that we cannot find the gl libs, so they're a fallback... at the least I recall it being something like that???
<boud> Wolthera_laptop: it's possible...
<boud> I sort of get antsy about it when people try the scripts that work for me and find problems -- there is something so utterly unstable about making builds!
...
<Wolthera_laptop> Yeah, it's been looking for libglu as long as it has been in the repo: https://phabricator.kde.org/rKRITA95858d5fbb8575f48c462ce0093e31bf92be3210
<Wolthera_laptop> To prevent a segfault.
<Wolthera_laptop> So it's not even a falback.

Reproducible: Always

Steps to Reproduce:
docker pull centos:6

(cd src/ && git checkout krita/3.0.1)

docker run -ti -v $(pwd)/src:/krita centos:6 /bin/bash
cd /krita/packaging/linux/appimage/
bash build-deps.sh  # 2h45mn, 5-6GB
docker commit XXXXXX  # 3-4mn
docker tag YYYYYY krita-deps

docker run -ti -v $(pwd)/src:/krita -v $(pwd)/build:/krita_build -v $(pwd)/out:/out krita-deps /bin/bash
bash build-krita.sh  # 1h
bash build-image.sh


Actual Results:  
# bash build-image.sh
...
++ xargs
++ cut -d '>' -f 2
++ grep libsasl2.so.2
++ ldconfig -p
+ cp /usr/lib64/libsasl2.so.2 ./usr/lib/
++ xargs
++ cut -d '>' -f 2
++ grep libGL.so.1
++ ldconfig -p
+ cp /usr/lib64/libGL.so.1 ./usr/lib/
++ xargs
++ cut -d '>' -f 2
++ grep libGLU.so.1
++ ldconfig -p
+ cp ./usr/lib/
cp: missing destination file operand after `./usr/lib/'
Try `cp --help' for more information.


Expected Results:  
Find libGLU and going on with the appimage build.
Comment 1 beuc 2016-09-11 19:23:54 UTC
Created attachment 101046 [details]
fix
Comment 2 Halla Rempt 2016-09-12 11:27:35 UTC
Git commit 2ac3c47e3ba91005143f4b59768f4e235e6d6762 by Boudewijn Rempt.
Committed on 12/09/2016 at 11:26.
Pushed by rempt into branch 'master'.

Though why and wherefore I don't know since I have obviously been
building the appimages I make without that devel package in the yum
install line.

M  +1    -1    packaging/linux/appimage/build-deps.sh

http://commits.kde.org/krita/2ac3c47e3ba91005143f4b59768f4e235e6d6762