When doing alt+tab with capslock key turned on, alt+tab dialog doesn't disappear like normal. Reproducible: Always Steps to Reproduce: 1. Turn capslock on 2. Do Alt+tab
The reason for that is that the shift modifier is still on. The relevant code area in Tabbox is: void TabBox::modifiersChanged(Qt::KeyboardModifiers mods) { if (m_noModifierGrab || !(!mods)) { return; } which means that with shift still being on we don't ever get into the code path. This needs rethinking now that we properly handle capslock. I assume that cancelling the capslock would result in TabBox to close.
Yes, canceling the capslock makes TabBox to close.
Git commit ca6505e84cfd0740ad27cadaa7076b0c72f522b8 by Martin Gräßlin. Committed on 13/09/2016 at 11:04. Pushed by graesslin into branch 'master'. [autotests/integration] Add new test for triggering TabBox First test case highlight a problem that tabbox doesn't close if capslock is on. M +1 -0 autotests/integration/CMakeLists.txt A +142 -0 autotests/integration/tabbox_test.cpp [License: GPL (v2)] M +1 -1 tabbox/tabbox.h http://commits.kde.org/kwin/ca6505e84cfd0740ad27cadaa7076b0c72f522b8
Git commit c71b002b24bed549e4f8086901b9cda68e7c5951 by Martin Gräßlin. Committed on 14/09/2016 at 11:26. Pushed by graesslin into branch 'master'. [wayland] Fix release of TabBox on Wayland Summary: The interaction is changed to trigger the check for release from the TabBoxInputFilter instead of reacting on modifier changes. That way it's possible to check for the relevant modifiers getting released instead of getting all modifiers in. Also this means that the checks are only performed when relevant. Reviewers: #kwin, #plasma_on_wayland, bshah Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D2773 M +0 -2 autotests/integration/tabbox_test.cpp M +4 -1 input.cpp M +4 -5 tabbox/tabbox.cpp M +1 -1 tabbox/tabbox.h http://commits.kde.org/kwin/c71b002b24bed549e4f8086901b9cda68e7c5951