Bug 368579 - The pager doesn't fit desktop names into the boxes anymore
Summary: The pager doesn't fit desktop names into the boxes anymore
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Pager (show other bugs)
Version: master
Platform: Other Linux
: NOR minor
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-11 07:50 UTC by Heiko Becker
Modified: 2016-09-19 07:52 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot (4.71 KB, image/png)
2016-09-11 07:50 UTC, Heiko Becker
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Heiko Becker 2016-09-11 07:50:03 UTC
The previous pager (5.7.x) seems to have centered the desktop name and cut away overlapping text. Currently it overlaps over the border and into the next box.

Not entirely sure what the best approach would be, though. Cutting the text or making the boxes fit the text.

Reproducible: Always
Comment 1 Heiko Becker 2016-09-11 07:50:26 UTC
Created attachment 101030 [details]
Screenshot
Comment 2 Eike Hein 2016-09-16 18:55:20 UTC
Git commit 5c941198a9f6294608588d863bc105488426249e by Eike Hein.
Committed on 16/09/2016 at 18:54.
Pushed by hein into branch 'Plasma/5.8'.

Fix desktop label clipping.

M  +15   -1    applets/pager/package/contents/ui/main.qml

http://commits.kde.org/plasma-desktop/5c941198a9f6294608588d863bc105488426249e
Comment 3 Eike Hein 2016-09-19 07:52:12 UTC
Git commit cb7f58b14d800be7b6ddb65b7d772afa2325d825 by Eike Hein.
Committed on 19/09/2016 at 07:51.
Pushed by hein into branch 'Plasma/5.8'.

Pick up on virtual desktop name changes at runtime.

Summary:
Includes a fix for refresh() being called too many times because
UniqueConnection doesn't work.

However, this revealed that KWindowSystem::desktopNamesChanged
is emitted many times, which Martin should take a look at.

Reviewers: #plasma, davidedmundson, graesslin

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D2806

M  +19   -5    applets/pager/plugin/pagermodel.cpp

http://commits.kde.org/plasma-desktop/cb7f58b14d800be7b6ddb65b7d772afa2325d825