Bug 368518 - git master - Layout automatically re-sizes widgets when clicking a transition in Timeline, then clicking away from it.
Summary: git master - Layout automatically re-sizes widgets when clicking a transition...
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-09 19:27 UTC by Unknown
Modified: 2016-09-28 21:08 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Unknown 2016-09-09 19:27:07 UTC
When I click on a transition in the timeline, then click away from it to a different clip in the timeline, the layout automatically re-sizes, somehow, when it shouldn't. I'm assuming this is a left-over from when we disabled the properties widget from automatically appearing after selecting timeline clips?

Reproducible: Always

Steps to Reproduce:
1. Add two clips to the timeline.
2. Put a transition between them.
3. Left-click the transition.
4. Click away from transition to other widget, clip in timeline, etc.


Actual Results:  
Layout automatically re-sizes widgets to something other than the current layout.

Expected Results:  
Layout shouldn't change at all.

Bug discovered while using Kdenlive 16.11.70 git master build via ppa:kdenlive/kdenlive-master.

Ubuntu GNOME 16.10 beta 1, GNOME 3.20 desktop environment.

KDE Frameworks 5.24.0
Qt 5.6.1
Comment 1 Unknown 2016-09-10 04:17:32 UTC
UPDATE #1 - The OP seems to be the case with my laptop, running a 1280x720 resolution screen. My editing station, running 1920x1080, only seems to automatically highlight the Properties widget when I left-click a transition in the timeline, but there is no automatic re-sizing of the layout. I assume these two reactions are related.
Comment 2 Wegwerf 2016-09-19 18:26:56 UTC
Unfortunately, I've never seen such a resizing behavior myself while working with Kdenlive. I've tried to reproduce it my making my Kdenlive window rather small and loading a fat project with lots of transitions. However, no cigar.
Comment 3 Wegwerf 2016-09-19 18:30:21 UTC
Jesse, beats me, just after sending the previous message, I toyed around further ... and got it to reproduce. So the exact steps for me:
1. Resize Kdenlive to a small window, such as less than 1024x768 or so. Make sure that the timeline takes up around the half or more of vertical space. Have the property pane visible, and above the timeline (can it placed in-line with the timeline at all, I don't know).
2. Click on a transition in the timeline.
3. Click on a clip with some effects apply.
Now the timeline gets slightly taller, as the property pane seems to resize.

So, confirmed :)
Comment 4 Wegwerf 2016-09-19 18:31:15 UTC
(I could need more than 4 layouts...) :)
Comment 5 Unknown 2016-09-19 18:34:31 UTC
Ha, thanks for verifying Wegwerf. I'm almost certain this is related to the old behavior when the layout would immediately highlight the Properties widget after a clip or transition was left-clicked in the Timeline. I believe this because my laptop screen is 1366x768, and the Properties widget used to default a minimum size when a clip was chosen in the Timeline. If the Properties widget was smaller, it would force itself to be the minimum size, re-sizing the whole layout in the process.

This appears to be the exact same behavior.
Comment 6 Wegwerf 2016-09-19 18:49:52 UTC
That reminds me to revive that old behavior, as the new one is driving me crazy. But don't be afraid, I would make it an option though. :)
Comment 7 Unknown 2016-09-19 19:32:41 UTC
Appreciate it being adapted into an option. ;P Haha, seriously though, you're doing awesome stuff with the patching, lately.
Comment 8 Jean-Baptiste Mardelle 2016-09-28 21:08:57 UTC
Git commit ea60a6cba12d9430f9a73d6f01fd1f2a93ac5769 by Jean-Baptiste Mardelle.
Committed on 28/09/2016 at 21:07.
Pushed by mardelle into branch 'Applications/16.08'.

Don't unnecessarily expand effect stack when unselecting a transition

M  +4    -2    src/effectstack/effectstackview2.cpp

http://commits.kde.org/kdenlive/ea60a6cba12d9430f9a73d6f01fd1f2a93ac5769