Bug 368487 - Text doesn't fit
Summary: Text doesn't fit
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Image & Slideshow wallpaper plugins (show other bugs)
Version: 5.7.4
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-09 10:39 UTC by Salvo "LtWorf" Tomaselli
Modified: 2016-09-13 17:37 UTC (History)
2 users (show)

See Also:
Latest Commit: http://commits.kde.org/plasma-workspace/f78fbac8ff98790ebbb864f00f6f69b131d527b5
Version Fixed In:
Sentry Crash Report:

Attachments
screenshot of the issue (52.71 KB, image/png)
2016-09-09 10:39 UTC, Salvo "LtWorf" Tomaselli 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Salvo "LtWorf" Tomaselli 2016-09-09 10:39:23 UTC 
See the screenshot

Reproducible: Always
Comment 1 Salvo "LtWorf" Tomaselli 2016-09-09 10:39:48 UTC 
Created attachment 100992 [details]
screenshot of the issue
Comment 2 Salvo "LtWorf" Tomaselli 2016-09-09 10:40:19 UTC 
Talking about the "change every…" text, that doesn't fit.
Comment 3 Marco Martin 2016-09-09 15:50:26 UTC 
is it an high dpi screen?
Comment 4 Salvo "LtWorf" Tomaselli 2016-09-09 18:04:14 UTC 
1920x1080, 15 inches screen
Comment 5 David Edmundson 2016-09-13 17:37:33 UTC 
Git commit f78fbac8ff98790ebbb864f00f6f69b131d527b5 by David Edmundson.
Committed on 13/09/2016 at 16:35.
Pushed by davidedmundson into branch 'master'.

Don't constrain width of Text field on translated text

Summary:
This caused it to be cropped on some translations.

This patch only sets the minimum size to force it to line up with the form layout,
but still allow the text to be larger if needed.

Also tidy up other use of directly setting width/anchors in a layout.

Test Plan:
Checked English layout matched up
Changed text to "asdfasdfadsfasdfljasdfjadlf" and checked that still fit

Reviewers: #plasma, mart

Reviewed By: mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D2729

M  +5    -9    wallpapers/image/imagepackage/contents/ui/config.qml

http://commits.kde.org/plasma-workspace/f78fbac8ff98790ebbb864f00f6f69b131d527b5