Bug 368418 - Add audio -> "Bitrate" column to Details view mode
Summary: Add audio -> "Bitrate" column to Details view mode
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: view-engine: details mode (show other bugs)
Version: 17.04.2
Platform: Neon Linux
: NOR wishlist
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-07 19:22 UTC by KDE Neon user
Modified: 2017-09-22 04:56 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description KDE Neon user 2016-09-07 19:22:45 UTC
This column is essential for people working with multiple audio files.

Reproducible: Always
Comment 1 Nate Graham 2017-09-04 22:59:47 UTC
The appropriate string in kbalooroledprovider.cpp is bitRate. This works using the expected diff, but the column will express the bitrate using an integer ("193000") instead of a more nicely-formatted string like "193.0 kB/s". Take a look at KBalooRolesProvider::durationFromValue() at the bottom of the file for an idea of how to format the string nicely.
Comment 2 Nate Graham 2017-09-11 02:55:40 UTC
Submitted a patch: https://phabricator.kde.org/D7763
Comment 3 Nate Graham 2017-09-22 04:56:53 UTC
Git commit 76698ff82cf5e88c1ea2e0686ce7450cf558af97 by Nate Graham.
Committed on 22/09/2017 at 04:56.
Pushed by ngraham into branch 'master'.

Add Bitrate to Dolphin's Additional Information

Summary:
Adds Bitrate to Dolphin's Additional information columns.

Test Plan:
Tested in KDE Neon. A bitrate column can be added and shows the bitrate in kb/s:

{F3907210}

Works for audio as well as video files!

Reviewers: #dolphin, #kde_applications, broulik, aacid, dfaure, emmanuelp

Reviewed By: #dolphin, #kde_applications, emmanuelp

Subscribers: rkflx, alexeymin, anthonyfieroni

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D7763

M  +1    -0    src/kitemviews/kfileitemmodel.cpp
M  +1    -1    src/kitemviews/kfileitemmodel.h
M  +13   -0    src/kitemviews/private/kbaloorolesprovider.cpp
M  +6    -0    src/kitemviews/private/kbaloorolesprovider.h

https://commits.kde.org/dolphin/76698ff82cf5e88c1ea2e0686ce7450cf558af97