Bug 368356 - Show amount sign on lost focus
Summary: Show amount sign on lost focus
Status: RESOLVED FIXED
Alias: None
Product: skrooge
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Kubuntu Linux
: NOR wishlist
Target Milestone: 25.1.0
Assignee: Guillaume DE BURE
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-06 20:03 UTC by vicnet
Modified: 2016-09-08 19:40 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description vicnet 2016-09-06 20:03:46 UTC
It will be helpful if amount sign could be automatically added if absent when quitting the widget.
Currently, it is added only when add/modify operation.

Reproducible: Always

Steps to Reproduce:
1. In amount edit widget, enter a number without sign
2. Quit edit (tab or mouse)


Actual Results:  
The amount stay as it is entered.

Expected Results:  
The sign + or - could be add.

This could avoid a mistake when omitting the sign as the sign will be show before the operation edition is finished.
Comment 1 Stephane MANKOWSKI 2016-09-06 20:10:33 UTC
Hi Vicnet,

If the sign is entered (+ or -), then this sign is used for the created/updated operation.
If the sign is not entered by the user, then the sign is automatically added by skrooge by using the category.

So, it means that we need to know the category to be able to automatically compute the sign of the operation. so, this can not be done when the focus is lost.

Is my answer acceptable?
Comment 2 vicnet 2016-09-08 19:09:17 UTC
I understand, perhaps adjust the amount sign when category is just selected ?

Also this useful information (sign from category) could be added in doc:
https://docs.kde.org/trunk5/fr/extragear-office/skrooge/operations.html#operation_properties
https://docs.kde.org/trunk5/en/extragear-office/skrooge/operations.html#operation_properties
or in "Operation creation" paragraph...
Comment 3 Stephane MANKOWSKI 2016-09-08 19:40:23 UTC
Git commit fd654830493963b2c8cc5ac114ec971e4cbdb8bb by Stephane Mankowski.
Committed on 08/09/2016 at 19:40.
Pushed by smankowski into branch 'master'.

Show amount sign on lost focus
Update documentation

M  +1    -0    CHANGELOG
M  +1    -0    doc/index.docbook

http://commits.kde.org/skrooge/fd654830493963b2c8cc5ac114ec971e4cbdb8bb