Bug 368342 - graphical depiction of group border in timeline is one frame too short
Summary: graphical depiction of group border in timeline is one frame too short
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface & Miscellaneous (show other bugs)
Version: 16.08.0
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-06 15:17 UTC by Wegwerf
Modified: 2016-09-12 06:18 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wegwerf 2016-09-06 15:17:01 UTC
Especially when working at higher zoom levels in Kdenlive's timeline, it becomes visible that the dashed border that depicts and surrounds a group of clips and transitions in the timeline is actually shown one frame too short. While the left border/beginning of a group is shown correclty, the right border/end looks as if one frame too short. The reason may be actually that the border falls on the *beginning* of the final frame. However, the border should be drawn up to the *end* of the final frame instead.

As it is, the group display is slightly misleading at higher zoom levels.

Reproducible: Always
Comment 1 Jean-Baptiste Mardelle 2016-09-11 20:16:33 UTC
Git commit 6a6ad3742f3e28d82162f83ffdc1be94fda63f1e by Jean-Baptiste Mardelle.
Committed on 11/09/2016 at 20:15.
Pushed by mardelle into branch 'master'.

Fix Recent regression - groups lost on project opening
Fix group width 1 frame too short

M  +1    -1    src/mainwindow.cpp
M  +2    -2    src/timeline/abstractgroupitem.cpp

http://commits.kde.org/kdenlive/6a6ad3742f3e28d82162f83ffdc1be94fda63f1e
Comment 2 Jean-Baptiste Mardelle 2016-09-11 20:18:20 UTC
Git commit b7425707071a6955d50be6f58a5d86dc173bb25d by Jean-Baptiste Mardelle.
Committed on 11/09/2016 at 20:17.
Pushed by mardelle into branch 'Applications/16.08'.

Fix Recent regression - groups lost on project opening
Fix group width 1 frame too short

M  +1    -1    src/mainwindow.cpp
M  +2    -2    src/timeline/abstractgroupitem.cpp

http://commits.kde.org/kdenlive/b7425707071a6955d50be6f58a5d86dc173bb25d
Comment 3 Wegwerf 2016-09-12 06:18:54 UTC
Thank you very much!