kopete fails to build against mediastreamer 2.14 /build/kdenetwork-kopete/src/kopete-16.08.1/protocols/jabber/libjingle/talk/session/phone/linphonemediaengine.cc: In constructor 'cricket::LinphoneVoiceChannel::LinphoneVoiceChannel(cricket::LinphoneMediaEngine*)': /build/kdenetwork-kopete/src/kopete-16.08.1/protocols/jabber/libjingle/talk/session/phone/linphonemediaengine.cc:156:37: error: cannot convert 'OrtpLogLevel' to 'const char*' for argument '1' to 'void ortp_set_log_level_mask(const char*, int)' ortp_set_log_level_mask(ORTP_FATAL); ^ /build/kdenetwork-kopete/src/kopete-16.08.1/protocols/jabber/libjingle/talk/session/phone/linphonemediaengine.cc:162:45: error: invalid conversion from 'int' to 'MSFactory* {aka _MSFactory*}' [-fpermissive] audio_stream_ = audio_stream_new(-1, -1, 0); /* -1 means that function will choose some free port */ ^ /build/kdenetwork-kopete/src/kopete-16.08.1/protocols/jabber/libjingle/talk/session/phone/linphonemediaengine.cc:162:45: error: too few arguments to function 'AudioStream* audio_stream_new(MSFactory*, int, int, bool_t)' Reproducible: Always
Created attachment 100980 [details] patch This patch fixes the build for me. I can't test that it works though, as I don't have a jabber account supporting jingle.
Created attachment 101315 [details] Improved patch The attached patch works also for building with old versions.
Hi Fabian Vogt! Can you cleanup your patch and post it to git.reviewboard.kde.org to kopete group?
(In reply to Pali Rohár from comment #3) > Hi Fabian Vogt! Can you cleanup your patch and post it to > git.reviewboard.kde.org to kopete group? I can do that, but I never tried to use it with linphone. If anyone can confirm that it still works, I'll submit it for review.
Those are probably only compile errors... I can review changes. Real testing will be harder as I have older libphone version which do not produce compile errors and it is working fine (testing kopete vs kopete). Also my automated builds of kopete on all supported and future ubuntu versions passe, see: https://launchpad.net/~pali/+archive/ubuntu/kopete/+packages So verification if compilation is really fixed must be done by somebody already affected by this bug. But I have no problem of merging this patch to kopete master as this I believe will be straightforward.
Ok, I made a review request on https://git.reviewboard.kde.org/r/129325/
Hi, We have now the same issue on Mageia6.
(In reply to David Geiger from comment #7) > We have now the same issue on Mageia6. Problem is because external mediastreamer library changed its API. I have not find any information about it yet, nor how to port old applications. Proposed patch pass NULL pointer to some functions, but again I did not find anything about it, that this is really correct solution. Passing NULL on "random" place without understood 'WHY?' is wrong solution. I would suggest to report bug to mediastreamer project, that they broke API and existing application... And without providing any information what to do...
Created attachment 114432 [details] Non-working skeleton patch against Debian version 4:17.08.3-1 Hi, I am part of the Linphone team at Debian and tried to patch kopete. This bug is keeping us from upgrading Linphone. Unfortunately, I have unrelated build problems with kopete, and cannot get the build process to stop at an error. The patch is against Debian version 4:17.08.3-1. I am posting my untested, non-working skeleton patch for now. I am happy to cooperate if upstream has additional pointers. Thank you!
Felix has created a patch that builds fine both against old and new mediastreamer2 libraries and submitted it to https://phabricator.kde.org/D15956
A possibly relevant merge request was started @ https://invent.kde.org/network/kopete/-/merge_requests/10