Bug 368331 - To display the eraser mode
Summary: To display the eraser mode
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Brush engines (show other bugs)
Version: 3.0
Platform: Kubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-06 11:43 UTC by yustas
Modified: 2022-07-12 12:18 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description yustas 2016-09-06 11:43:18 UTC
Displaying of the eraser mode within the brush cursor would be helpful to determinate the current brush mode during the frequent usage of "e" shortcut. In the present time you need to rotate your head to find the brush mode state on the toolbar or to draw a stroke for the determination of the current brush mode. These actions are excess.
Comment 1 Scott Petrovic 2016-10-24 13:43:56 UTC
Some people are extremely picky about what goes on their cursor (and I would personally not want to see this). Having to "rotate your head" is a very small usability concern. There is already multiple types of visual feedback you get when it is on. Selecting Erase mode is a very concrete feature, so you have to explicitly turn it on for it to work. You need to be very forgetful that you turned something on a second or two ago.

If this does get added, it need to be able to be turned off so the cursor doesn't show it. This isn't asked for frequently, so I would default to not showing it.
Comment 2 yustas 2016-10-25 14:16:21 UTC
Sometimes I work in Krita about 8-12 houres in a day and sometimes I am forced to change the tools like Brush, Transform and Eraser every 3-4 second. I prefer charge my memory with another things, it is not to remember every my action with the pen.

It would be correct to have this option switchable and turned off by default.
Comment 3 Guillaume Audirac 2016-12-20 17:03:32 UTC
I would also be in favor of such a feature. Identifying from the cursor appearance that the brush eraser mode is enabled would make it more comfortable. Even more with large screens and "Show Canvas Only" mode.
Changing its shape would NOT be ideal as all brushes has their own shape, but simply filling the cursor shape with a plain color, the same as the outline color basically, and only when the stylus tip is not pressed (so when the brush is not drawing).
With this behavior, it might even not be necessary to add an additional configuration entry to enable/disable this feature.
Comment 4 Scott Petrovic 2016-12-20 17:40:00 UTC
One potential solution would be to do something subtle like make the cursor outline a dotted line instead of a solid line. Obviously it wouldn't help much if you had your cursor set to a shape like a black dot though. Maybe a solution is good enough for cursors that have shapes. Otherwise we will need another icon or something showing you are in erase mode
Comment 5 lempikq 2018-11-10 10:39:53 UTC
I'm in favor as well.

I think it could work the same as selections. Simple display "minus sign" next to the brush reticle. Selecting wheter it's on or off could be in settings as other reticle options.
Comment 6 David REVOY 2019-09-16 20:55:05 UTC
I would not want an additional icon next to the outline of the brush; but I'm also in favor of adding another feedback -more obvious- while the brush switch to eraser mode. For that, I would propose another color for the brush outliner shape; since Krita 4.x it's possible to setup the base color of the brush outliner shape (Bright green by default, with XOR blending mode; so often visible as dark purple by default on white canvas). I would like a new color slot to setup the color while in "Eraser mode" (with a XOR blending mode too for this mode): so users can tweaks their setup if they want no change at all (using same color) subtle (just a darker green) or a dramatic feedback (picking a red/pink, see gif under):

Preference panel mockup with additional option:
https://www.peppercarrot.com/extras/temp/2019-09-16_screenshot_155945.jpg 

Gif animation of a red brush outline erasing (55,158,255 RGB + XOR):
https://www.peppercarrot.com/extras/temp/2019-09-16_eraser-red-colored-outline_test.gif

Also, I link this recent topic on forum for ref ( https://forum.kde.org/viewtopic.php?f=288&t=162411&sid=9744d2a20cd5acc2f5d9357779ba5023 ) and thanks @Tymond for redirecting me here.
Comment 7 lempikq 2019-09-17 10:39:54 UTC
The color change David REVOY suggests seems certainly nice if it would be something added I'd be for combining it with Scott Petrovic's suggestion.

Dotted - or perhaps dashed - outline together with the possibility for the color from David's reply and apply the dotted/dashed for the reticle if possible too in case you use only reticle without preview outline.

Not sure how much is this feasible though?
Comment 8 David REVOY 2019-09-17 10:57:53 UTC
@viktorsladek: I agree for dotted, or something affecting the shape. Taking into account users with color blindness is important. Thanks for bringing this point.
Comment 9 Scott Petrovic 2019-09-18 00:28:46 UTC
FYI - I just made a merge request to add this in. You can comment on that if you have any comments.

https://invent.kde.org/kde/krita/merge_requests/147
Comment 10 mcoudert 2020-03-15 10:08:49 UTC
(In reply to Scott Petrovic from comment #9)
> FYI - I just made a merge request to add this in. You can comment on that if
> you have any comments.
> 
> https://invent.kde.org/kde/krita/merge_requests/147

As recommanded by Tiar on the krita-artist forum, i've made a poll with all the options proposed in the thread you linked.

The poll is accessible here
https://krita-artists.org/t/having-a-visual-change-when-in-eraser-mode-community-poll/4107

Hope this feature will be on a future realease...
Comment 11 tomtomtomreportingin 2022-07-12 12:18:36 UTC
https://invent.kde.org/graphics/krita/-/merge_requests/1426 should be a good enough compromise to mark this report as resolved.