Bug 368240 - Possibility to disable downloading Hot new Stuff
Summary: Possibility to disable downloading Hot new Stuff
Status: RESOLVED FIXED
Alias: None
Product: frameworks-knewstuff
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Jeremy Whiting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-04 13:48 UTC by Dennis Knorr
Modified: 2016-09-07 21:43 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Knorr 2016-09-04 13:48:01 UTC
Hi,
we (the Cityadministration of Munich) do not want that our users can load hot new stuff like for example wallpapers or themes from external sources.
We provide via systeminstallation wallpapers, themes, pictures, which can be choosable. But we do not want that users can load them from the network.
Therefore we would propose that there's a key for the kiosk-mode which disables "Get Hot new Stuff"


Reproducible: Always

Steps to Reproduce:
1. Right-click on the Desktop
2. choose Desktop Settings

Actual Results:  
For example: 
Clicking on "Get New Wallpapers" provide the possibility to the user, choosing/downloading new Wallpapers.

Expected Results:  
For example:
The user cannot fetch/lookup/install Wallpapers with "Get New Wallpapers"
Comment 1 Jeremy Whiting 2016-09-06 17:46:38 UTC
Would you prefer the kiosk key hid the "Get Hot new Stuff" button completely? Or show a message when clicked saying it has been disabled by the administrators?
Comment 2 Kai Uwe Broulik 2016-09-06 22:16:42 UTC
Ideally both. As we don't have QML bindings yet, none of the Plasma dialogs nor many KCMs would follow that, so a message in the download dialog should definitely be there and we can deal with the cosmetics later.
Comment 3 Jeremy Whiting 2016-09-06 22:31:10 UTC
Well, QML Bindings are there in a branch and should land shortly afaik. Ok, I've never used any kiosk stuff before. Is there a tutorial somewhere about how it works these days? Googling got me https://dot.kde.org/2005/03/02/kde-kiosk-tutorial which links to a dead techbase page... How does kiosk work these days? Some QSetting somewhere?
Comment 4 Kai Uwe Broulik 2016-09-07 05:49:19 UTC
if (!KAuthorized::authorize("ghns")) { ... }
Comment 5 Jeremy Whiting 2016-09-07 15:59:59 UTC
Created a patch which works in every case except the one you want... Investigating why that is. The patch is here: https://git.reviewboard.kde.org/r/128856/
Comment 6 Jeremy Whiting 2016-09-07 21:43:01 UTC
Git commit 2a7ac6f0753427f865fc9013868990cb3b530ecf by Jeremy Whiting.
Committed on 07/09/2016 at 21:42.
Pushed by whiting into branch 'master'.

Add KAuthorized checks to allow disabling of ghns in kdeglobals.
REVIEW:128856

M  +6    -0    src/button.cpp
M  +29   -0    src/downloaddialog.cpp
M  +8    -0    src/downloaddialog.h

http://commits.kde.org/knewstuff/2a7ac6f0753427f865fc9013868990cb3b530ecf