Bug 368234 - Please make file filter and URL filter configurable separately
Summary: Please make file filter and URL filter configurable separately
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Martin Sandsmark
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-04 09:17 UTC by Markus Trippelsdorf
Modified: 2016-10-18 22:12 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Trippelsdorf 2016-09-04 09:17:48 UTC
Currently both the file filter and the URL filter can only be enabled or disabled together.
The file filter gets into my way very often, but I find the URL filter very useful.
(The file filter also increases the CPU time of konsole noticeably.) 

So please separate the two features and let the user enable or disable them individually.
Thanks.

Reproducible: Always
Comment 1 Martin Sandsmark 2016-09-04 12:15:27 UTC
https://git.reviewboard.kde.org/r/128828/
Comment 2 Markus Trippelsdorf 2016-09-04 13:49:28 UTC
Thanks for the quick patch.
Unfortunately it doesn't work fully yet.
With URL filter enabled and file filter disabled. URLs are _not_ underlined.
If I enable both options and hit apply and then disable the file filter again,
the  URL filter works OK for the current session. 
But it stops working if I close konsole and start it again.
Comment 3 Martin Sandsmark 2016-09-04 15:50:14 UTC
I made a dumb typo, should work better now.
Comment 4 Markus Trippelsdorf 2016-09-04 16:01:36 UTC
(In reply to Martin Sandsmark from comment #3)
> I made a dumb typo, should work better now.

Ok never mind, it works fine now.
Comment 5 Martin Sandsmark 2016-10-18 22:12:09 UTC
Git commit b2b044cf2ad3b7a400fd032650acfa37c4e440b9 by Martin T. H. Sandsmark.
Committed on 18/10/2016 at 22:11.
Pushed by sandsmark into branch 'master'.

Make the config of file filters and url filters separate

REVIEW: 128828

M  +18   -3    src/EditProfileDialog.cpp
M  +1    -0    src/EditProfileDialog.h
M  +12   -2    src/EditProfileDialog.ui
M  +3    -1    src/Profile.cpp
M  +9    -0    src/Profile.h
M  +36   -4    src/SessionController.cpp
M  +6    -0    src/SessionController.h
M  +32   -35   src/TerminalDisplay.cpp
M  +0    -16   src/TerminalDisplay.h
M  +0    -1    src/ViewManager.cpp

http://commits.kde.org/konsole/b2b044cf2ad3b7a400fd032650acfa37c4e440b9