Bug 368093 - Color schemes collide with the ones from Plasma's breeze
Summary: Color schemes collide with the ones from Plasma's breeze
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: git master (please specify the git hash!)
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-01 09:21 UTC by Heiko Becker
Modified: 2016-10-24 11:49 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Heiko Becker 2016-09-01 09:21:01 UTC
f46fed0b5ee8a1ceaba126fbf0114c37f7671768 introduced the installation of three color schemes. Two of the three are already installed by Plasma's breeze package and collide with each other: BreezeDark.colors and BreezeHighContrast.colors.

Reproducible: Always
Comment 1 Halla Rempt 2016-09-01 10:52:16 UTC
But isn't the location where we store the color schemes completely independent from the one plasma uses? And Krita doesn't look at the location where plasma stores the color schemes.
Comment 2 Heiko Becker 2016-09-01 11:02:32 UTC
(In reply to Boudewijn Rempt from comment #1)
> But isn't the location where we store the color schemes completely
> independent from the one plasma uses? 

No, it might be independent in theory, but the relevant cmake files default to the same location.


krita (krita/data/themes/CMakeLists.txt):
install(
...
BreezeDark.colors
BreezeHighContrast.colors
...
 ${schemefiles} DESTINATION ${DATA_INSTALL_DIR}/color-schemes


breeze (CMakeLists.txt):
INSTALL(FILES colors/BreezeDark.colors DESTINATION ${DATA_INSTALL_DIR}/color-schemes/)
INSTALL(FILES colors/BreezeHighContrast.colors DESTINATION ${DATA_INSTALL_DIR}/color-schemes/)
Comment 3 Halla Rempt 2016-10-24 11:38:43 UTC
Ah, you're right. I'll fix that...
Comment 4 Halla Rempt 2016-10-24 11:49:37 UTC
Git commit f50c5949365e333e9762b635722251a8406b3f81 by Boudewijn Rempt.
Committed on 24/10/2016 at 11:48.
Pushed by rempt into branch 'master'.

When Krita is built by distributions for installation into /usr,
the breeze themes we borrowed shouldn't be installed, because all
color themes share the same installation directory.

But when we build for Windows, OSX or AppImages, we do want to have
these styles available because they're very nice.

M  +2    -0    CMakeLists.txt
M  +9    -3    krita/data/themes/CMakeLists.txt

http://commits.kde.org/krita/f50c5949365e333e9762b635722251a8406b3f81