Bug 368001 - plugins menu entry empty without kipi-plugins
Summary: plugins menu entry empty without kipi-plugins
Status: RESOLVED FIXED
Alias: None
Product: gwenview
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Gwenview Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-30 10:02 UTC by Harald Sitter
Modified: 2016-10-19 10:42 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Sitter 2016-08-30 10:02:31 UTC
gwenview can be built with libkipi (kde applications), if kipi-plugins (digikam) aren't installed there won't be anything to list though.

when built with libkipi a 'Plugins' menu entry becomes available, without kipi-plugins however this entry has no nodes making it look broken.



Reproducible: Always



Expected Results:  
3 ways to solve this come to mind

# No plugins = No menu

When no plugins are available the menu doesn't get shown. So the visibility condition changes from (builtWithLibKipi) to (builtWithLibKipi && !pluginsList.isEmpty). With this a user is expected to know that kipi-plugins should be installed to gain additional features. Alternatively installing digikam will also enhance gwenview's capabilities.

# Custom install rigging

When no plugins are available a "fake" menu entry is created which employs a simple addon-install mechanic as seen in drkonqi to let distributions install kipi-plugins on demand. Namely this would call an executable that is meant to install kipi-plugins through whatever way necessary exitign either 0 or !0 from which gwenview can deduce whether or not it needs to reload the plugin list.

# Install through appstream

Alternatively we could solve this through appstream by having kipi-plugins provide a "global" metainfo file for "standard kipi plugins" or something alike, from gwenview we still have a fake menu entry but instead of calling out to some custom code it simply runs appstream://org.kde.kipi-plugins.desktop, which will bring up the desktop's software center to install kipi plugins.

# We always want them

kipi-plugins should be considered as a runtime requirement, to communicate this to distributors a runtime dependency information should be included in gwenview's cmake output.
Comment 1 Jonathan Riddell 2016-10-19 10:42:15 UTC
code added which offers to install kipi-plugins
https://git.reviewboard.kde.org/r/129072/