Bug 367990 - [Activity Pager] - Does not set Vertical Layout properly without corresponding Virtual Desktops
Summary: [Activity Pager] - Does not set Vertical Layout properly without correspondin...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Pager widget (show other bugs)
Version: 5.8.0
Platform: openSUSE Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-30 08:21 UTC by Michail Vourlakos
Modified: 2016-10-24 21:36 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michail Vourlakos 2016-08-30 08:21:25 UTC
I dont know if this is the place to report for Activity Pager,
feel free to forward me to the correct place.

Activity Pager uses the number of Visual Desktops for its layout when I think it shouldnt..

1. We have 3 Enabled activities, and we add the activity pager in a panel...
2. We set for "Visual Desktops", 1 Visual Desktop and 1 lines
this shows 3 activities in a line (this is correct)
3. We set for "Visual Desktops", 1 Visual Desktop and 3 lines
this shows again 3 activities in a line even if the panel is vertical (I think this is not correct)
4. We set for "Visual Desktops", 3 Visual desktops and 3 lines
this shows 3 activities in a column which is correct but the user may not want 3 Visual Desktops
for each activity in order to achieve this layout





Reproducible: Always
Comment 1 Michail Vourlakos 2016-10-08 21:47:07 UTC
remains in Plasma 5.8.0
Comment 2 Michail Vourlakos 2016-10-20 22:16:53 UTC
I am working on a patch for this,

current status is that the activity pager uses the virtual desktops layout in order to present itself,
I propose that for the activity pager there should be an horizontal or a  vertical layout which can be set through its settings...
Or it could be the default behavior(using vds layout),only horizontal,only vertical  

what do you think?
Comment 3 David Edmundson 2016-10-21 00:30:56 UTC
If we make it a 1D list, is there ever a case to have a vertical list in a horizontal panel? They don't really fit.

At which point maybe we don't need the option and can just use the Plasmoid.location?
Comment 4 Michail Vourlakos 2016-10-21 04:46:46 UTC
> If we make it a 1D list, is there ever a case to have a vertical list in a horizontal panel? They don't really fit.

yes, it depends from the height of the panel, which is something the user is setting.
1. My case is that I use 2-3 running activities and the rest are disabled, which fit with a little biger height in a vertical layout.
2. I also want the activities pager layout to correspond with what the "Activity Switcher" is presenting (this is something to be fixed also later, the activity pager is not showing the activities with the order the "Activity Switcher" does).
3. Setting only horizontal for a horizontal panel will create problems, for example if the panel's height is a little bigger then 2-3 activities would catch too much space.

I propose that the user should decide the layout with 3 choices:
1. Default (the current behavior which I dont think actually it makes any sense but because it is used very long could be also the defaul behavior)
2. Horizontal
3. Vertical

we could also drop choice (1), and use Horizontal for a horizontal panel by default, but the user could change this to vertical from pager settings and vice versa.
Comment 5 Michail Vourlakos 2016-10-24 16:27:27 UTC
I would like someone to review this please:

https://phabricator.kde.org/D3130

regards,
michail
Comment 6 Eike Hein 2016-10-24 21:36:28 UTC
Git commit 2a5580d486acb1754913b17c19409b66ddec4d84 by Eike Hein, on behalf of Michail Vourlakos.
Committed on 24/10/2016 at 21:35.
Pushed by hein into branch 'master'.

Improve Activity Pager Layout for horizontal and vertical cases

Adds option to configure layout.

M  +2    -1    applets/kicker/package/contents/ui/ItemGridDelegate.qml
M  +12   -0    applets/kicker/package/contents/ui/ItemGridView.qml
M  +9    -0    applets/pager/package/contents/config/main.xml
M  +13   -0    applets/pager/package/contents/ui/configGeneral.qml
M  +17   -7    applets/pager/package/contents/ui/main.qml

http://commits.kde.org/plasma-desktop/2a5580d486acb1754913b17c19409b66ddec4d84