When adding brackets after an if statement in break mode, the brackets created via autobracket are one indentation level too low. Reproducible: Always Steps to Reproduce: 1. create if statement "if(true) 2.hit enter to break down to next row 3.add bracket with autobrackets (should create two brackets) Actual Results: The brackets created are at the indentation level of the previous code and not of the if statement Expected Results: brackets should be created at the indentation level the same as the if statement for which the brackets correspond.
I think this might be because inserting a } automatically deindents, we need to fix that in case of autobraces. I have seen this behaviour, it's annoying.
Yeah, it is annoying. Reproduces on Kate too, so I guess it should be moved to ktexteditor bugs.
I can reproduce this in KDevelop 5.0.2 but NOT in Kate 16.08.3. This bug also happens after other keywords (like do, while, for) and other brackets. This bug only happens if tabs are used for indentation. The problem is that KDevelop uses spaces to fix the indentation level. If in the examples below the spaces are replaced with tabs the indentation would be correct. Editor configured to use tabs as indentation. . = space $ = tab Example 1: $if() Hit Enter $if() $$ Hit { $if() .{} ---------- Example 2: $$if() Hit Enter $$if() $$$ Hit { $$if() ..{} ---------- Since Kate does not increase the indentation after hitting enter it doesn't have to fix it. That may be the reason why I can not reproduce this bug in Kate. $if() Hit Enter $if() $ Hit { $if() ${}
Now I can also reproduce this also in Kate. This bug is directly related to the indention mode setting of ktexteditor. (Settings->Editor Component->Editing->Indention->Default-Indention-mode and Settings->Editor Component->Open/Save->Modi & File types->Indention-mode) With the "C++/Boost Style" and "C-Style" this bug can be reproduced. With the "Normal" mode this bug can not be reproduced.
Yes, I don't think this is specific to KDevelop. Moving to ktexteditor product.
I added some debug outputs to the "C Style" indentation script and it looks like the scripts `indent` function does not get called for the opening bracket "{" if auto brackets are enabled. Therefore the indentation level for the opening bracket does not get modified to match the if statement. In addition the auto bracket feature moves the cursor in between the two brackets and than calls the `indent` function for the closing bracket "}". Now the script does not find the opening bracket correctly (skips over it) since the script expects the cursor to be behind the closing bracket. The workaround below manually processes the opening bracket instead of closing one if "{|}" (| = cursor position) is in the current line. It seems to work quite well, but a proper fix would be nice. diff --git a/ktexteditor/src/script/data/indentation/cstyle.js b~/.local/share/katepart5/script/indentation/mycustomindentation.js index 86e72a7..5916506 100644 --- a/ktexteditor/src/script/data/indentation/cstyle.js +++ b~/.local/share/katepart5/script/indentation/mycustomindentation.js @@ -1,5 +1,5 @@ var katescript = { - "name": "C Style", + "name": "C Style Modified", "author": "Dominik Haumann <dhdev@gmx.de>, Milian Wolff <mail@milianw.de>", "license": "LGPL", "revision": 4, @@ -772,7 +772,11 @@ function processChar(line, c) return filler; } else if (firstPos == column - 1 && c == '}') { - var indentation = findLeftBrace(line, firstPos); + if (document.charAt(cursor) == '}' && document.charAt(cursor.line, cursor.column-1) == '{') + { + return processChar(line, '{') + } + var indentation = findLeftBrace(line, firstPos) if (indentation == -1) indentation = -2; return indentation;
Hmm, somehow this got lost. Dominik, any input for this?
I can not reproduce it anymore with KF 5.90 / Kate 21.12. Can anyone else confirm if this is still an issue?
Reproduced. Needed to use tabs
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/ktexteditor/-/merge_requests/267
Git commit 29122ad59afeced0296d23fb6153c4f04c008ac1 by Christoph Cullmann, on behalf of Waqar Ahmed. Committed on 27/01/2022 at 07:11. Pushed by cullmann into branch 'master'. When using tabs, use tabs to auto indent Related: bug 375529 M +1 -1 src/script/data/indentation/cstyle.js M +1 -0 src/utils/kateautoindent.cpp https://invent.kde.org/frameworks/ktexteditor/commit/29122ad59afeced0296d23fb6153c4f04c008ac1