Bug 367923 - kpackagetool5 does not create appdata files for types like "Plasma/Wallpaper" or "Plasma/LookAndFeel", but shows error
Summary: kpackagetool5 does not create appdata files for types like "Plasma/Wallpaper"...
Status: RESOLVED WORKSFORME
Alias: None
Product: frameworks-kpackage
Classification: Frameworks and Libraries
Component: default (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR major
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
: 368594 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-08-28 14:08 UTC by Friedrich W. H. Kossebau
Modified: 2020-12-01 18:43 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Friedrich W. H. Kossebau 2016-08-28 14:08:11 UTC
As seen on CI with KF5 pre-5.26 (but not locally with older KF5 5.24), e.g. in
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/395/consoleFull:
--- 8< ---
19:44:47 CMake Warning at /srv/jenkins/install/ubuntu/x86_64/g++/kf5-qt5/frameworks/kpackage/inst/usr/lib/x86_64-linux-gnu/cmake/KF5Package/KF5PackageMacros.cmake:45 (message):
19:44:47   couldn't generate metainfo for org.kde.image: Package type
19:44:47   "Plasma/Wallpaper" not found
19:44:47 
19:44:47   Error: Can't find plugin metadata:
19:44:47   /home/jenkins/sources/plasma-workspace/kf5-qt5/wallpapers/image/imagepackage
19:44:47 
19:44:47 
19:44:47 Call Stack (most recent call first):
19:44:47   /srv/jenkins/install/ubuntu/x86_64/g++/kf5-qt5/frameworks/plasma-framework/inst/usr/lib/x86_64-linux-gnu/cmake/KF5Plasma/KF5PlasmaMacros.cmake:33 (kpackage_install_package)
19:44:47   wallpapers/image/CMakeLists.txt:31 (plasma_install_package)
--- 8< ---

--- 8< ---
19:44:44 CMake Warning at /srv/jenkins/install/ubuntu/x86_64/g++/kf5-qt5/frameworks/kpackage/inst/usr/lib/x86_64-linux-gnu/cmake/KF5Package/KF5PackageMacros.cmake:45 (message):
19:44:44   couldn't generate metainfo for org.kde.breeze.desktop: Package type
19:44:44   "Plasma/LookAndFeel" not found
19:44:44 
19:44:44   Error: Can't find plugin metadata:
19:44:44   /home/jenkins/sources/plasma-workspace/kf5-qt5/lookandfeel
19:44:44 
19:44:44 Call Stack (most recent call first):
19:44:44   /srv/jenkins/install/ubuntu/x86_64/g++/kf5-qt5/frameworks/plasma-framework/inst/usr/lib/x86_64-linux-gnu/cmake/KF5Plasma/KF5PlasmaMacros.cmake:33 (kpackage_install_package)
19:44:44   CMakeLists.txt:117 (plasma_install_package)
--- 8< ---

Not further investigated, only seen those warnings on CI.

Reproducible: Always
Comment 1 Rex Dieter 2016-09-11 14:04:44 UTC
*** Bug 368594 has been marked as a duplicate of this bug. ***
Comment 2 Rex Dieter 2016-09-11 14:06:16 UTC
Seeing this on fedora's minimal build environment too (local buids are fine?), when trying to build breeze and plasma-sdk components.  See also bug #368594
Comment 3 Rex Dieter 2016-09-11 14:20:31 UTC
Suspecting a missing runtime component of kpackagetool5, I found that  plasma-workspace contains (in plugins/kpackage/packagestructure):
plasma_packagestructure_lookandfeel.so
plasma_packagestructure_wallpaper.so

and those being present or not seems to be the difference between kpackagetool5 working to parse those package types.
Comment 4 Fabian Vogt 2017-05-09 11:25:16 UTC
This results in a build cycle in the openSUSE packages as plasma-workspace requires kwin during build, which requires breeze, which in turn requires plasma-workspace during build to generate the metainfo.

A workaround is to break the breeze/kwin runtime dependency and build plasma-workspace without breeze installed, but that should not be necessary.
Comment 5 Fabian Vogt 2017-05-09 14:09:47 UTC
Oh, and plasma-workspace itself needs plasma-workspace installed during build, due to:

[   91s] CMake Warning at /usr/lib64/cmake/KF5Package/KF5PackageMacros.cmake:58 (message):
[   91s]   warnings during generation of metainfo for org.kde.breeze.desktop: Package
[   91s]   type "Plasma/LookAndFeel" not found
[   91s] 
[   91s] Call Stack (most recent call first):
[   91s]   /usr/lib64/cmake/KF5Plasma/KF5PlasmaMacros.cmake:33 (kpackage_install_package)
[   91s]   CMakeLists.txt:115 (plasma_install_package)
Comment 6 Bhushan Shah 2017-05-11 11:41:53 UTC
This bug seems to be a non-issue,

1) original error in comment #0 was fixed in http://commits.kde.org/kpackage/100d1411256749ae79b8b74d6cdb78dda65c7188

2) Last bug in comment #5 is not a error but warning only.

Is there anything else we can do here? If so please re-open bug.
Comment 7 Fabian Vogt 2017-05-11 11:46:55 UTC
(In reply to Bhushan Shah from comment #6)
> This bug seems to be a non-issue,

How? I had to make a workaround in kpackage to always emit appdata, even if it's broken as the plugin was not installed so that we could build plasma: https://cgit.kde.org/kpackage.git/commit/?id=a0da2bd735d01155667ce21e87d553bcb69e3a6a

If it does not matter that the package type is not known during cmake runtime, it needs to be fixed differently. As far as I can tell moving the package type to plasma-framework is the best option here. It might also be possible to defer the kpackagetool5 invocation to cmake buildtime with proper deps instead of configure time.
Comment 8 Nate Graham 2020-12-01 18:24:22 UTC
Is this still an issue today?
Comment 9 Fabian Vogt 2020-12-01 18:43:40 UTC
I just checked build logs for breeze and plasma-workspace and couldn't find any instance of this error.