Bug 367816 - Icons in kickoff have varying stroke width
Summary: Icons in kickoff have varying stroke width
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Theme - Breeze (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-25 20:22 UTC by Kai Uwe Broulik
Modified: 2016-08-26 21:48 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Icons (16.08 KB, image/png)
2016-08-25 20:22 UTC, Kai Uwe Broulik
Details
kicker with computer, laptop and folder icon. (34.06 KB, image/png)
2016-08-25 22:04 UTC, andreas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Uwe Broulik 2016-08-25 20:22:06 UTC
The new black and white icons for kickoff tabs have varying widths, the lines of the favorites and application tabs are thinner than the ones for history and leave.

(Also, the laptop icon is missing/colored)

Reproducible: Always
Comment 1 Kai Uwe Broulik 2016-08-25 20:22:31 UTC
Created attachment 100757 [details]
Icons
Comment 2 Kai Uwe Broulik 2016-08-25 20:23:49 UTC
The "computer" icon is now a folder?! and computer-laptop is just missing.
Comment 3 andreas 2016-08-25 20:34:31 UTC
cause in the kickoff menu the computer section is mor places than anything else so for me a folder fit's better than a really generic computer icon. what does the computer/laptop icon mean? A folder icon would show easy what the section mean. for laptop it should be the same icon than for the default computer. in the icon theme when there is no computer-laptop icon is available it use the computer icon that's the reason the icon was missed. will add it.

about the different thickness all icons are available in two sizes 22px and 32px but it look like your system (hidpi isn't it?) show in bookmarks, apps the 32px one and in history and leave the 22px scaled up.
Comment 4 andreas 2016-08-25 22:04:30 UTC
Created attachment 100766 [details]
kicker with computer, laptop and folder icon.

I changed the computer/laptop icon to a folder icon cause in this section you see the places and two applications. but the main stuff are the places. In general the folder icon look better.

please give me the feedback if you want computer/laptop icon or folder.

the line thickness should be fixed.
Comment 5 Bhushan Shah 2016-08-26 03:09:44 UTC
(In reply to andreas from comment #4)
> I changed the computer/laptop icon to a folder icon cause in this section
> you see the places and two applications. but the main stuff are the places.
> In general the folder icon look better.

Point is, when icon name says "computer" you can't make it folder icon, if you want to replace icon, good way to do would be changing icon name in code which shows icon.
Comment 6 Kai Uwe Broulik 2016-08-26 10:40:29 UTC
The computer icon looks fine, the laptop looks shorter than the other ones, though. In any case, the "computer" icon needs to be restored asap and then we could think of changing it to another one by having Kickoff load a different icon.
Comment 7 Marco Martin 2016-08-26 10:59:03 UTC
(In reply to andreas from comment #4)
> Created attachment 100766 [details]
> kicker with computer, laptop and folder icon.
> 
> I changed the computer/laptop icon to a folder icon cause in this section
> you see the places and two applications. but the main stuff are the places.
> In general the folder icon look better.
> 
> please give me the feedback if you want computer/laptop icon or folder.

computer icon.
Comment 8 Marco Martin 2016-08-26 11:00:28 UTC
(In reply to andreas from comment #3)
> cause in the kickoff menu the computer section is mor places than anything
> else so for me a folder fit's better than a really generic computer icon.
> what does the computer/laptop icon mean? A folder icon would show easy what
> the section mean. for laptop it should be the same icon than for the default
> computer. in the icon theme when there is no computer-laptop icon is
> available it use the computer icon that's the reason the icon was missed.
> will add it.
> 
> about the different thickness all icons are available in two sizes 22px and
> 32px but it look like your system (hidpi isn't it?) show in bookmarks, apps
> the 32px one and in history and leave the 22px scaled up.

the normal icon (without size prefix) should be the thin one, the 22-whatever one should be the thick version
Comment 9 Kai Uwe Broulik 2016-08-26 19:59:30 UTC
Stroke width is fine now, thanks.
Comment 10 andreas 2016-08-26 21:48:35 UTC
Git commit 152b71df5b8e3270ad0d0cbfc78758c20c9e902e by andreas kainz.
Committed on 26/08/2016 at 21:47.
Pushed by andreask into branch 'master'.

add computer and laptop icon for kicker

M  +-    --    src/desktoptheme/breeze/icons/computer.svgz
M  +1    -1    src/desktoptheme/breeze/metadata.desktop

http://commits.kde.org/plasma-framework/152b71df5b8e3270ad0d0cbfc78758c20c9e902e