Bug 367710 - Enable highlighting in Scroll-bar Minimap for (just) Find
Summary: Enable highlighting in Scroll-bar Minimap for (just) Find
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-23 10:54 UTC by Richard Llom
Modified: 2022-01-16 19:57 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Llom 2016-08-23 10:54:53 UTC
The highlighting of searched strings in the scroll-bar minimap is very cool feature, however in its current implementation it has very poor ease of access and poor use.
Why? Because it is only shown when using the "Search & Replace" (S&R) dialog but not when using "Find". This is bad for several reasons:
1.  Often (here 99% of the time) one just wants to find text and not replace, so one wouldn't open S&R in the first place.
2. Kwrite doesn't has S&R (or it has also very poor ease of access), hence this feature isn't there available at all.
3. S&R is way too complicated for the average (non-developer) user.
4. S&R takes up way too much space (screen estate) of the window.

-> Therefore I propose to enable the Search highlighting in Scroll-bar Minimap for Find.

Which really should be a no-brainer and I'm kind of disappointed that one has to write a bug-report for such an obvious thing. I mean look at chromium, adobe pdf, etc. everywhere it is enabled on find, why  would you make such a feature so hidden, really??
/rant

Reproducible: Always
Comment 1 Kåre Särs 2016-08-23 11:56:30 UTC
Hi,

A bit negative feature request... :(

Yes, It would be nice to have the highlighting to the built-in Find also. The current find/find-next only searches from the cursor forward and highlights the word only because the highlight selected words feature. Only when you have pressed "Find All" would it be possible to show all the results in the mini-map/scrollbar. To add highlighting of all matches without "Find All" might need a change in how the search works.

The small Kate development team does not have infinite free time. Adding the matches to the scrollbar after "Find All" should not be a big thing. Patches are welcome :)

At the moment this feature just has not reached the top of the todo-list for any of the developers.
Comment 2 Christoph Cullmann 2016-09-06 08:55:52 UTC
Valid wish, patches are welcome.
Comment 3 Nate Graham 2017-12-08 12:54:29 UTC
Before we do this, we should probably improve the visual presentation of the find&replace minimap markers: Bug 367713
Comment 4 Christoph Cullmann 2019-05-19 15:05:44 UTC
Dear user, this wish list item is now closed, as it wasn't touched in the last year and no contributor stepped up to implement it.

The Kate/KTextEditor team is small and we can just try to keep up with fixing bugs.

Therefore wishes that show no activity for a years or more will be closed from now on to keep at least a bit overview about 'current' wishs of the users.
If you want your feature to be implemented, please step up to provide some patch for it.

If you think it is really needed, you can reopen your request, but keep in mind,
if no new good arguments are made and no people get attracted to help out to implement it,
it will expire in a year again.

We have a nice website https://kate-editor.org that provides all the information needed to contribute, please make use of it.

Patches can be handed in via https://phabricator.kde.org/differential/

Greetings
Christoph Cullmann
Comment 5 Nate Graham 2019-05-21 16:02:57 UTC
I think this makes sense. In fact, I think it makes sense to try to collapse quick find into the big find-and-replace. Having these be different is sort of weird and awkward.
Comment 6 Kåre Särs 2019-05-21 18:34:54 UTC
I have already implemented the scrollbar marks for "Find All" in the built-in find.

As we only search one match forward at a time in the non-all-searches, it would not make sens to add only one scroll-bar-mark at a time. The whole point with the marks is to show where in the document we have matches. Displaying one mark for the already visible area is pointless...

So is this now Resolved?