Bug 367705 - Archive function does not switch to relative paths
Summary: Archive function does not switch to relative paths
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: Rendering & Export (other bugs)
Version First Reported In: 16.08.0
Platform: Mint (Ubuntu based) Linux
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-23 08:43 UTC by ByteHamster
Modified: 2018-07-21 20:29 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:
snd.noise: low_hanging+


Attachments
Patch to fix this bug (1.29 KB, patch)
2016-11-06 18:05 UTC, ByteHamster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ByteHamster 2016-08-23 08:43:14 UTC
In previous versions (one of the 0.9.x releases), I could use the archive function to transfer the project to another PC. It copied all media files to sub-folders inside the tar archive ("images", "sounds", "videos") and updated the project.kdenlive file to reference "$CURRENTPATH/videos/xy" instead of "/mnt/xy".

Using 16.08.0, the files are still copied to the tar archive, but the paths inside the project.kdenlive file stay untouched. So if I unpack the file on another PC and try to open the project, it does not find any of the media files (it tries to find them on /mnt/xy instead of using a relative path).

Reproducible: Always

Steps to Reproduce:
1. Create a new project and add a media file
2. Project->Archive and select "Compressed archive"
3. Move archive to another PC or rename original files
4. Extract and open archived project

Actual Results:  
Kdenlive tries to find media files in the original location

Expected Results:  
Kdenlive should use the copy it created while archiving (using a relative path)
Comment 1 ByteHamster 2016-11-06 18:05:03 UTC
Created attachment 102073 [details]
Patch to fix this bug
Comment 2 Jean-Baptiste Mardelle 2016-11-07 21:21:45 UTC
Git commit a8e87f2975913a627266332e424da87c6896834a by Jean-Baptiste Mardelle.
Committed on 07/11/2016 at 21:21.
Pushed by mardelle into branch 'master'.

Fix incorrect Url handling in archive feature

M  +25   -25   src/project/dialogs/archivewidget.cpp

http://commits.kde.org/kdenlive/a8e87f2975913a627266332e424da87c6896834a
Comment 3 Jean-Baptiste Mardelle 2016-11-07 21:25:05 UTC
Git commit 2871dee6c51c827f41ad074c5a5d6b7435c69e08 by Jean-Baptiste Mardelle.
Committed on 07/11/2016 at 21:22.
Pushed by mardelle into branch 'Applications/16.08'.

Fix incorrect Url handling in archive feature

M  +25   -25   src/project/dialogs/archivewidget.cpp

http://commits.kde.org/kdenlive/2871dee6c51c827f41ad074c5a5d6b7435c69e08
Comment 4 Jean-Baptiste Mardelle 2016-11-07 21:31:51 UTC
Thanks for your report and patch. There were indeed several issues in the way the archive widget handled the paths. I committed a patch in the 16.08 branch that correct the biggest issues.

Patch is here:
http://commits.kde.org/kdenlive/2871dee6c51c827f41ad074c5a5d6b7435c69e08

I also have pushed the fix to the testing PPA:
https://launchpad.net/~kdenlive/+archive/ubuntu/kdenlive-testing

In a quick test, it seems to fix the bug you describe. Is there a way for you to test it ?
Comment 5 ByteHamster 2016-11-07 21:48:45 UTC
I just tested your commit. It fully fixes the "Compressed archive" function - thank you very much!

Additionally, it fixes the "Cannot create directory" issues when using the un-compressed archive function. Unfortunately, the un-compressed archive still contains absolute paths, so half of the archive function remains broken. Would be great if you could fix that too. (My attempt did not touch the un-compressed archive function, so it would be great if you could fix it completely ;) )