konsole: close tab button is almost invisible when I use breeze dark theme Reproducible: Always Steps to Reproduce: 1.set your system theme to breeze dark 2.open konsole 3. Actual Results: close tab button is almost invisible. See the screenshot. Expected Results: close tab button has better visibility.
Created attachment 100722 [details] barely visible Konsole icon in the tab bar
I'm shame... It's not close tab button, it's konsole icon. Editing summary...
Hmm, dark icons are just always going to have visibility issues with dark themes. Breeze icon folks, would you be open to tweaking Konsole's icon to give it a subtle light-colored outline?
Git commit e1fde67a69c748b76f8210ac22f58e76b53d9717 by Kurt Hindenburg, on behalf of Nate Graham. Committed on 28/12/2018 at 03:27. Pushed by hindenburg into branch 'master'. Only show tab icon if the user has specifically chosen one Summary: This patch introduces a UI change: tabs only show an icon if it's not the default one; that is to say, only if the user has actually customized the icon. There are several reasons for this: 1. **Conceptual:** When only non-default profile icons show up in the tab, it does a better job of highlighting the fact that a non-default profile is being used. 2. **Aesthetic:** you no longer have the same icon in every tab by default, which looks bad and causes the eye to ignore it over time. 3. **Icon-specific:** the `utilities-terminal` icon doesn't look good against a dark background (https://bugs.kde.org/show_bug.cgi?id=367696) 4. **Code hygiene:** reduces a bit of redundancy in the session controller code. Related: bug 401864 FIXED-IN: 19.04.0 Test Plan: Open multiple tabs and make one of them use a profile with a non-default icon: {F6502534, size=full} Verify that bell signals still cause tabs to get icons. Reviewers: #konsole, #vdg, ndavis, hindenburg Reviewed By: #konsole, #vdg, ndavis, hindenburg Subscribers: fabianr, abetts, hindenburg, konsole-devel Tags: #konsole Differential Revision: https://phabricator.kde.org/D17747 M +9 -7 src/SessionController.cpp https://commits.kde.org/konsole/e1fde67a69c748b76f8210ac22f58e76b53d9717
The tab bar does not show the app icon anymore, but Konsole icon is still barely visible in window decoration and task manager when breeze dark is used.
The Konsole icon has, since that screenshot was taken, the usual 1px highlight and shadow, and combined with the gradient change from top-down to top-left, it has overall much better contrast. Should we close this as fixed?
I think so, yeah.
Created attachment 155384 [details] konsole icon on Plasma 5.26.5 The icon looks barely visible to me on Plasma 5.26.5 yet. Operating System: Arch Linux KDE Plasma Version: 5.26.5 KDE Frameworks Version: 5.102.0 Qt Version: 5.15.8 Graphics Platform: Wayland
Looks okay to me, TBH. I guess we have differing definitions of "barely visible. :) I'll admit it blends in a bit. But it's a dark icon on a dark background; in such a circumstance, it's never going to have amazing contrast just because of what it is.