Bug 366869 - Binding loop for AppletConfiguration.qml in org.kde.plasma.desktop/contents/configuration/
Summary: Binding loop for AppletConfiguration.qml in org.kde.plasma.desktop/contents/c...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: general (show other bugs)
Version: 5.7.3
Platform: openSUSE Linux
: NOR normal
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-16 18:30 UTC by Michail Vourlakos
Modified: 2016-08-28 09:05 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michail Vourlakos 2016-08-16 18:30:09 UTC
whenever an applet opens its configuration dialog a warning is appearing informing for a binding loop for width and height at lines 163 and 164:
---
width: categoriesScroll.viewport.width 
height: Math.max(categoriesScroll.viewport.height, categories.height)
---

this is the categories in the configuration dialog.. the child of a QtControls.ScrollView is using its viewport to count its size and that creates a binding loop. I changed them with:
---------------
width: units.gridUnit * 7 - 4
height: categories.childrenRect.height
-----------

the bindings were removed and the appearance looks the same...

after that my configuration dialogs in all my applets open faster

Reproducible: Always

Steps to Reproduce:
1. open a configuration dialog e.g. the taskmanager
2.
3.
Comment 1 David Edmundson 2016-08-28 00:45:39 UTC
Thanks, but that's not a valid fix. 

>. the child of a QtControls.ScrollView is using its viewport to count its size 

Than in itself isn't a binding loop - you need to tell me how the viewport is based on the size of the contents it to be a loop... and the viewport of a scrollview isn't.

The only way that can happen is if it's stuck on whether to show a scrollbar on not, as that is something that affects the viewport size, and is sort of  based on the contents. It's a common-ish bug.

This is something that seems to have been accidentally fixed properly in 817b27f44d4ab64a395f34ede1f734a43b7712bf

Please reopen if that's not the case for you.
Comment 2 Michail Vourlakos 2016-08-28 09:05:12 UTC
Thank u David...