Bug 366758 - Krita flips the image horizontally when opening a file if the mirror mode is active
Summary: Krita flips the image horizontally when opening a file if the mirror mode is ...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: 3.0
Platform: Microsoft Windows Microsoft Windows
: NOR minor
Target Milestone: ---
Assignee: Krita Bugs
URL: https://drive.google.com/file/d/0B5OS...
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-14 17:04 UTC by comm.ass
Modified: 2016-08-15 13:48 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description comm.ass 2016-08-14 17:04:44 UTC
When opening a file, if the mirror mode is active, the image shows flipped horizontally. In the URL of this issue I've put a link to a zip file containing images of the problem.

The workaround is to deactivate the mirror mode and then opening the file.

Reproducible: Always

Steps to Reproduce:
1. Open a file (file 1.png of the zip file)
2. Activate the horizontal mirror mode (file 2.png of the zip file)
3. Close the image (file 3.png of the zip file)
4. Open the file again (file 4.png of the zip file)

Actual Results:  
The image is flipped horizontally

Expected Results:  
The image shouldn't be flipped

The workaround is to deactivate the mirror mode before closing the image.

Another minor bug is that although the horizontal mirror line is shown, the icon isn't active.
Comment 1 Halla Rempt 2016-08-15 12:56:01 UTC
Hi,

Thanks for your report. I can confirm the issue.
Comment 2 Halla Rempt 2016-08-15 13:19:45 UTC
This is a more general issue than it seemed at first. We have two mirror functions:

* The View/Canvas/Mirror View (hotkey M) that should mirror only the display and only affects the display
* The horizontal/vertical mirror painting thing that shows the mirror line(s) and affects painting.

And the two seem confused in the code, where toggling the mirror view two times also toggles the canvas deco.
Comment 3 Halla Rempt 2016-08-15 13:48:31 UTC
Git commit b61e346508259c779d367c0348a9ef7b9cc3cf22 by Boudewijn Rempt.
Committed on 15/08/2016 at 13:48.
Pushed by rempt into branch 'master'.

The one has nothing to do with the other:

* The View/Canvas/Mirror View (hotkey M) that should mirror only the
display and only affects the display

* The horizontal/vertical mirror painting thing that shows the mirror
line(s) and affects painting.

M  +5    -0    libs/ui/KisView.cpp
M  +2    -0    libs/ui/KisView.h
M  +0    -6    libs/ui/canvas/kis_canvas_controller.cpp
M  +24   -18   libs/ui/canvas/kis_coordinates_converter.cpp
M  +9    -9    libs/ui/canvas/kis_coordinates_converter.h
M  +0    -2    libs/ui/kis_canvas_resource_provider.h
M  +6    -20   libs/ui/kis_mirror_manager.cpp
M  +1    -2    libs/ui/kis_mirror_manager.h
M  +12   -12   libs/ui/tests/kis_coordinates_converter_test.cpp

http://commits.kde.org/krita/b61e346508259c779d367c0348a9ef7b9cc3cf22