Bug 366567 - Allow choosing several duplicate results [patch]
Summary: Allow choosing several duplicate results [patch]
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Searches-Similarity (show other bugs)
Version: 5.1.0
Platform: Debian testing Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-09 21:31 UTC by Simon
Modified: 2016-11-13 21:26 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.4.0
Sentry Crash Report:


Attachments
Allow selection of multiple duplicates (7.44 KB, patch)
2016-11-13 14:04 UTC, Simon
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Simon 2016-08-09 21:31:56 UTC
Currently in the duplicate part of fuzzy search I can only select one group of duplicates at a time. This is ok if you have just a few duplicates. However I have lots of duplicates and want to sort/remove them. For this case the current state is useless, I would have to go through hundreds of duplicates one by one. If I could choose all/several of them I could then apply tags and use filters on all of the duplicates. Thus I could choose a subset of all picture that have a duplicate and remove them.

Reproducible: Always

Steps to Reproduce:
1. Search for duplicates
2. Try to select multiple items

Actual Results:  
Only one selection possible.

Expected Results:  
Select as many duplicate groups as you want.
Comment 1 Simon 2016-11-13 14:04:57 UTC
Created attachment 102207 [details]
Allow selection of multiple duplicates

This patch adjusts the fuzzysearchview to handle multiple selected duplicates and extends SearchesJob to process all SAlbums, not just the first. The process of displaying albums stays the same, ImageAlbumModel::startListJob has only been adjusted to pass over all SAlbums instead of dropping all but the first.
Comment 2 caulier.gilles 2016-11-13 21:26:44 UTC
Git commit 131b3009cb03f7b4fae1e18f6aa0eaaa0741bc22 by Gilles Caulier.
Committed on 13/11/2016 at 21:23.
Pushed by cgilles into branch 'master'.

Apply patch #102207 to permit multiple selection in duplicates search albums list-view.
FIXED-IN: 5.4.0

M  +2    -1    NEWS
M  +19   -12   libs/database/dbjobs/dbjob.cpp
M  +9    -4    libs/database/dbjobs/dbjobinfo.cpp
M  +3    -2    libs/database/dbjobs/dbjobinfo.h
M  +9    -6    libs/models/imagealbummodel.cpp
M  +1    -1    utilities/fuzzysearch/findduplicatesalbum.cpp
M  +14   -6    utilities/fuzzysearch/findduplicatesview.cpp
M  +1    -1    utilities/fuzzysearch/findduplicatesview.h

http://commits.kde.org/digikam/131b3009cb03f7b4fae1e18f6aa0eaaa0741bc22