Bug 366519 - edit-clear-locationbar-ltr needs to be mirrored
Summary: edit-clear-locationbar-ltr needs to be mirrored
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: visual-bugs-null
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-08 11:43 UTC by Kai Uwe Broulik
Modified: 2016-09-04 09:45 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Uwe Broulik 2016-08-08 11:43:32 UTC
The edit-clear icon needs to exist in two variants, one for left-to-right languages and right-to-left (eg. Hebrew). Currently, both edit-clear-locationbar-rtl and edit-clear-locationbar-ltr point to the right.

edit-clear-locationbar-ltr needs to point to the right as if it were placed *left of* the text field.

Note: the LTR in the name does *not* mean "this is for left to right languages" but "this arrow points left to right" (ie. the opposite)

See for example:
http://www.iconarchive.com/show/oxygen-icons-by-oxygen-icons.org/Actions-edit-clear-locationbar-rtl-icon.html
and
http://www.iconarchive.com/show/oxygen-icons-by-oxygen-icons.org/Actions-edit-clear-locationbar-ltr-icon.html

Reproducible: Always
Comment 1 Kai Uwe Broulik 2016-08-08 11:44:10 UTC
Gosh, this confuses me. Currently they both point to the *left* :)
Comment 2 Kai Uwe Broulik 2016-09-04 09:45:23 UTC
Git commit 7acd29bb6e8c9e24e473df0962e96e409fd011ab by Kai Uwe Broulik, on behalf of David Edmundson.
Committed on 04/09/2016 at 09:44.
Pushed by broulik into branch 'master'.

Fix all edit-clear-location-ltr icons

icons with -ltr suffix should have the icon going from left to right and
are used (counterintuitively) in situations where the text layout is
right to left, if the normal icon points rtl.

This patch changes the icons from being a symlink to the same icon to being a copy mirrored in inkscape.
REVIEW: 128694

T  +62   -1    icons/actions/16/edit-clear-locationbar-ltr.svg
T  +62   -1    icons/actions/22/edit-clear-locationbar-ltr.svg
T  +62   -1    icons/actions/24/edit-clear-locationbar-ltr.svg

http://commits.kde.org/breeze-icons/7acd29bb6e8c9e24e473df0962e96e409fd011ab