Bug 366492 - OFX Import dialog does not import OFX files
Summary: OFX Import dialog does not import OFX files
Status: RESOLVED FIXED
Alias: None
Product: kmymoney
Classification: Applications
Component: general (show other bugs)
Version: git (master)
Platform: Other Linux
: NOR major
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-07 12:00 UTC by JantarMantar
Modified: 2018-01-09 11:47 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Patch to kmymoney.cpp to allow importing of OFX files (1.62 KB, patch)
2017-08-04 21:58 UTC, Alexandre
Details

Note You need to log in before you can comment on or make changes to this bug.
Description JantarMantar 2016-08-07 12:00:28 UTC
Recently (as of github.com commit: 5e883c11a3ef5001c67ceb680701dbc4bb97ce95), OFX Import dialog does nothing. The dialog comes up, (even looks strange because it doesn't limit file types to OFX types) , allows to pick a file and then closes with no action.

Reproducible: Always

Steps to Reproduce:
1. From File->Import menu select "OFX..."
2. Notice that the dialog' Filter field is unusual that it doesn't filer only OFX types and Name: field says 'kde-import'
3. Select an OFX file to import


Actual Results:  
1. Dialog closes with no action nor any error message
2. There are no messages on terminal either.

Expected Results:  
Selected OFX file should be processed or an error displayed if it's an invalid file.


This is a regression from github.com commit: 4604c7eca3bc50902a60fdbfe95ee47482f487c8
At this commit, the OFX Import was successfully working
Comment 1 tamort 2017-04-22 22:10:29 UTC
This exact behavior is seen in b1468e678e5fc0a4092c11b63c3e5255f4659a8c
Comment 2 Alexandre 2017-08-04 21:58:30 UTC
Created attachment 107078 [details]
Patch to kmymoney.cpp to allow importing of OFX files
Comment 3 Alexandre 2017-08-04 22:01:06 UTC
KF5 seems to have changed the API to select files and the capability of importing OFX is commented on the code. This patch allows a single file to the imported, f more than one is selected only the first one is imported. It also corrects some seg faults that occur when I import some OFX files.
Comment 4 Thomas Baumgart 2017-08-05 07:14:22 UTC
Alexandre, thanks for the proposed patch. I'll take care of it. I just wonder what the following change is needed for:

-  QString accId;
+  QString accId = QString();

The additional assignment does not make any sense in my eyes. Maybe, you can share the reasons.
Comment 5 Alexandre 2017-08-05 14:47:17 UTC
Thomas, thanks for the correction, that statement is redundant. I was debugging some seg fault and changed this function a few times and forced that initialization to check and forgot to remove it.
Comment 6 Thomas Baumgart 2018-01-09 11:47:45 UTC
This must have been fixed in the meantime. I cannot duplicate it with current 5.0 branch.