Bug 366475 - Buttons in notifications
Summary: Buttons in notifications
Status: RESOLVED FIXED
Alias: None
Product: kdeconnect
Classification: Applications
Component: common (other bugs)
Version First Reported In: unspecified
Platform: Other All
: NOR wishlist
Target Milestone: ---
Assignee: Albert Vaca Cintora
URL:
Keywords:
: 393965 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-08-06 16:37 UTC by Dmitrii Chermnykh
Modified: 2019-03-22 18:05 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitrii Chermnykh 2016-08-06 16:37:53 UTC
Please add buttons from android notification (http://i.imgur.com/Jz7Idie.png) to desktop notifications. 

Reproducible: Always
Comment 1 Andrey Sitnik 2018-09-25 06:46:38 UTC
GSConnect project needs this feature too

https://github.com/andyholmes/gnome-shell-extension-gsconnect/issues/207
Comment 2 Nicolas Fella 2018-09-26 13:37:39 UTC
*** Bug 393965 has been marked as a duplicate of this bug. ***
Comment 3 Nicolas Fella 2019-02-08 23:00:42 UTC
Git commit 957975898bfc22b17ebfff1321f9c89f753a34c2 by Nicolas Fella.
Committed on 08/02/2019 at 22:54.
Pushed by nicolasfella into branch 'master'.

Add actions to notifications

Summary:
When Android sends a list of possible actions add them to the notification. When the action is triggered send a package containing the id and the action back

Test Plan: Send dummy notification, see the actions, trigger it, look for received package on Android

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: apol, kdeconnect, broulik, mtijink, #kde_connect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D12293

M  +2    -1    plugins/notifications/kdeconnect_notifications.json
M  +21   -1    plugins/notifications/notification.cpp
M  +2    -0    plugins/notifications/notification.h
M  +10   -0    plugins/notifications/notificationsdbusinterface.cpp
M  +1    -0    plugins/notifications/notificationsdbusinterface.h
M  +2    -0    plugins/notifications/notificationsplugin.h

https://invent.kde.org/kde/kdeconnect-kde/commit/957975898bfc22b17ebfff1321f9c89f753a34c2
Comment 4 Nicolas Fella 2019-02-13 17:43:56 UTC
Git commit e65743c0c163d68235c88e8cfb4464abbe41a3c4 by Nicolas Fella.
Committed on 13/02/2019 at 17:43.
Pushed by nicolasfella into branch 'qmlsettings'.

Add actions to notifications

Summary:
When Android sends a list of possible actions add them to the notification. When the action is triggered send a package containing the id and the action back

Test Plan: Send dummy notification, see the actions, trigger it, look for received package on Android

Reviewers: #kde_connect, apol

Reviewed By: #kde_connect, apol

Subscribers: apol, kdeconnect, broulik, mtijink, #kde_connect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D12293

M  +2    -1    plugins/notifications/kdeconnect_notifications.json
M  +21   -1    plugins/notifications/notification.cpp
M  +2    -0    plugins/notifications/notification.h
M  +10   -0    plugins/notifications/notificationsdbusinterface.cpp
M  +1    -0    plugins/notifications/notificationsdbusinterface.h
M  +2    -0    plugins/notifications/notificationsplugin.h

https://invent.kde.org/kde/kdeconnect-kde/commit/e65743c0c163d68235c88e8cfb4464abbe41a3c4
Comment 5 Nicolas Fella 2019-03-22 16:07:29 UTC
Git commit c2cd60773b5738537f099cb306382f6d039a564a by Nicolas Fella.
Committed on 22/03/2019 at 16:07.
Pushed by nicolasfella into branch 'master'.

Send notification actions

Summary:
Store PendingIntents from notification actions. Send list of notifications to desktop and trigger Intent when matching packet arrives.

Test Plan: Create test notification, trigger package is received correctly. Whether intent.send() is actually successful is NOT yet tested.

Reviewers: #kde_connect, sredman

Reviewed By: #kde_connect, sredman

Subscribers: sredman, apol, MatMaul, kdeconnect, mtijink, #kde_connect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D12294

M  +48   -3    src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java

https://invent.kde.org/kde/kdeconnect-android/commit/c2cd60773b5738537f099cb306382f6d039a564a