Bug 366416 - Speed Effect on cropped clip can mess up the timeline
Summary: Speed Effect on cropped clip can mess up the timeline
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: Effects & Transitions (show other bugs)
Version: 16.04.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Vincent PINON
URL: https://www.youtube.com/watch?v=ElvrA...
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-04 17:24 UTC by Chris
Modified: 2016-08-08 16:00 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris 2016-08-04 17:24:07 UTC
If you have a CROPPED video clip (i.e. cut part of the ending) and apply the speed effect to it, depending on the setting of the speed, this clip may overlap another clip on the same video track. 
Saving and Reloading the project in this state will mess up the timeline. However even working on the project as this overlap happens can yield some rather random results (and/or a crash).

Reproducible: Always

Steps to Reproduce:
1. Make a new project with at least two video clips of any length.
2. Add the first clip to VIDEO 1 and crop part of its end.
3. Add the second clip on the same track (VIDEO 1) right after the first
4. Apply a SPEED EFFECT to the first video track.
5. Drag the speed slider around until the video clip will eventually overlap the following one. This may be tricky and requires some playing around with the speed slider.
6. After both clips overlap each other, save the project (the project is already messed up at this point and kdenlive may not play the second clip if playing the project or even crash)
7. Load your project again and see how the second video clip is pushed back.

Actual Results:  
The second video clip is pushed back in the timeline. But only after the project reloads.

Expected Results:  
As it happend if the first video clip is NOT cropped, kdenlive will automatically crop it so it cannot overlap the following clip.

This bug ONLY WORKS if you crop the end of the clip BEFORE you apply the speed effect to it.
Comment 1 Wegwerf 2016-08-05 17:36:44 UTC
I can mostly confirm this using recent beta 16.07.90; with the recent timeline checks the second clip will be automatically removed from the timeline on reloading the project. However, I don't see any pushback, the fllowing clip simply get hidden behind the expanding speed clip.
Comment 2 Jean-Baptiste Mardelle 2016-08-06 23:28:14 UTC
Git commit a1f1f11934f914c438e05ec72f25110822c9d53e by Jean-Baptiste Mardelle.
Committed on 06/08/2016 at 23:27.
Pushed by mardelle into branch 'Applications/16.08'.

Fix corruption on speed change

M  +10   -9    src/timeline/track.cpp

http://commits.kde.org/kdenlive/a1f1f11934f914c438e05ec72f25110822c9d53e
Comment 3 Wegwerf 2016-08-08 16:00:23 UTC
Works as expected, at least when using a fresh project. I had some issues with an existing project where the speed clip would still overlay the next following clip, and afterwards resisted to be deleted from the timeline. However, I think that we can close this bug now as fixed. If there should be issues surfacing with old projects, we would need a new report with a precise recipe to reproduce the regression anyway. Thank you very much for fixing this bug, Jean-Baptiste!