Bug 366366 - Please provide a package for qtvirtualkeyboard
Summary: Please provide a package for qtvirtualkeyboard
Status: RESOLVED FIXED
Alias: None
Product: neon
Classification: KDE Neon
Component: Packages Unstable Edition (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Neon Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-03 06:15 UTC by Martin Flöser
Modified: 2016-08-08 09:58 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Flöser 2016-08-03 06:15:34 UTC
Please provide a package for qtvirtualkeyboard which is a new module in Qt 5.7 and make it a runtime dependency of kwin_wayland.

Reproducible: Always

Steps to Reproduce:
1. Use kwin_wayland
2. Try to open virtual keyboard

Actual Results:  
It's not there because there is no qtvirtualkeyboard

Expected Results:  
Virtual keyboard just working in kwin_wayland
Comment 1 Bhushan Shah 2016-08-03 06:20:40 UTC
I did initial packaging for it at : https://github.com/plasma-phone-packaging/qtvirtualkeyboard for Plasma mobile.. Though I guess someone needs to take a closer look at it and clean it up.. and submit it to debian perhaps...
Comment 2 Harald Sitter 2016-08-03 12:15:04 UTC
I think you just volunteered to upstream this.

- copyright file is incomplete
- should put examples into -dev package
- should put cmake file into -dev package
- possibly should split qml from actual inputplugin (not actually sure that is useful though)
- build-depends on kde-pkg-tools but doesn't seem to use it at all
- shouldn't buildpdep on qt5-default
- all qt builddeps should be tightly versioned
- the rules file seems a bit ugh

should export these flags:
export CFLAGS := $(shell dpkg-buildflags --get CFLAGS) $(shell dpkg-buildflags --get CPPFLAGS)
export CXXFLAGS := $(shell dpkg-buildflags --get CXXFLAGS) $(shell dpkg-buildflags --get CPPFLAGS)
export LDFLAGS := $(shell dpkg-buildflags --get LDFLAGS) -Wl,--as-needed
export QT_SELECT := qt5

- shouldn't phony override_dh_auto_test or document why that is absolutely necessary
Comment 4 Jonathan Riddell 2016-08-08 09:55:01 UTC
also added as recommends to kwin_x11 in master (neon dev unstable) packaging
Comment 5 Bhushan Shah 2016-08-08 09:58:44 UTC
It should be recommends of kwin_wayland and not kwin_x11