Bug 366361 - createReadWriteLock and createMetadataProcessor should not be pure virtual
Summary: createReadWriteLock and createMetadataProcessor should not be pure virtual
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-Plugins (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-02 21:06 UTC by Johannes Zarl-Zierl
Modified: 2022-02-06 05:53 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.1.0


Attachments
Make createReadWriteLock and createMetadataProcessor not-pure. (1.17 KB, patch)
2016-08-02 21:06 UTC, Johannes Zarl-Zierl
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Zarl-Zierl 2016-08-02 21:06:47 UTC
Created attachment 100422 [details]
Make createReadWriteLock and createMetadataProcessor not-pure.

If an application does not implement the features HostSupportsReadWriteLock and HostSupportsMetadataProcessing, the current API still expects the host application to provide the functions createReadWriteLock and createMetadataProcessor.

Both methods are already implemented in interface.cpp, so it seems to me that making them pure virtual was actually a mistake...
Comment 1 Maik Qualmann 2016-08-03 16:37:17 UTC
Git commit 860f11a91c9398397246bf554e24ff9b8b3adc6d by Maik Qualmann.
Committed on 03/08/2016 at 16:35.
Pushed by mqualmann into branch 'master'.

apply patch #100422 to make implemented methods not pure virtual
FIXED-IN: 5.1.0

M  +2    -2    src/interface.h

http://commits.kde.org/libkipi/860f11a91c9398397246bf554e24ff9b8b3adc6d
Comment 2 caulier.gilles 2016-08-04 09:37:35 UTC
Git commit 593cf8bf10349ce459fdf26c800f9b5b3301a4b3 by Gilles Caulier.
Committed on 04/08/2016 at 09:36.
Pushed by cgilles into branch 'master'.

fix ABI/API ID since pure virtual method fingerprints have changed.

M  +3    -2    CMakeLists.txt

http://commits.kde.org/libkipi/593cf8bf10349ce459fdf26c800f9b5b3301a4b3