Bug 366305 - Add a message at startup about the lack of temporary space to perform Undo operations
Summary: Add a message at startup about the lack of temporary space to perform Undo op...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Showfoto-Core (show other bugs)
Version: 5.0.0
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-31 14:43 UTC by ar@home
Modified: 2018-04-29 06:34 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0.0


Attachments
Showfoto terminal output with comments (10.83 KB, text/x-log)
2016-07-31 18:16 UTC, Frank Steinmetzger
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ar@home 2016-07-31 14:43:56 UTC
for most operations the 'undo' function does not work.

Reproducible: Always

Steps to Reproduce:
1. Open image
2. Change color to BW or resize or ...
3. accept changes
4. Edit/undo last operation

Actual Results:  
Modifications on the image persist.

Expected Results:  
Modifications on the image should be undone

This is on version 3.5.0  under ubuntu 14.04
Comment 1 Frank Steinmetzger 2016-07-31 15:03:26 UTC
Same here, Digikam 5.0.0 on Plasma 5.7.2, Qt 5.6.1, Frameworks 5.24.0 on Gentoo Linux.
Comment 2 Maik Qualmann 2016-07-31 17:38:41 UTC
Strangely, this is absolutely not here to reproduce. All processing steps can undo. Possibly a problem with the undo cache. Please share the output of the console.

Maik
Comment 3 Frank Steinmetzger 2016-07-31 18:16:24 UTC
Created attachment 100399 [details]
Showfoto terminal output with comments

There you go. I opened a file in Showfoto, resized and saved it. I inserted appropriate comments into the log, beginning with "# --------".
Comment 4 Maik Qualmann 2016-07-31 18:30:08 UTC
Free space available in Editor cache [ "/home/frank/.cache/showfoto/" ] in Mbytes:  753

The minimum free disk space for undo cache is 1024 Mbytes.

Maik
Comment 5 Frank Steinmetzger 2016-07-31 18:58:29 UTC
I see. I replaced ~/.cache/showfoto with a symlink to /var/tmp, which is a 24 G ramdisk on this machine. Undo works now, thanks for the hint.

I think some kind of notification would be helpful for other unsuspecting users, though. I saw that log line, too. But I did not think much of it because it looks like a statement, rather than an error message.
Comment 6 caulier.gilles 2016-08-01 08:05:08 UTC
I agree that Undo manager need to show some message box with relevant information about missing free space to complete undo registration in temporary directory.

Gilles Caulier
Comment 7 ar@home 2016-08-07 15:14:31 UTC
(In reply to Frank Steinmetzger from comment #5)
> I see. I replaced ~/.cache/showfoto with a symlink to /var/tmp, which is a
> 24 G ramdisk on this machine. Undo works now, thanks for the hint.
> 
> I think some kind of notification would be helpful for other unsuspecting
> users, though. I saw that log line, too. But I did not think much of it
> because it looks like a statement, rather than an error message.

Here the  shofoto cache already resided on /var/tmp/kdecache-'user'/showFoto which was located on a logical volume that had only 800M left. Putting /var/tmp/ on an LV with 4G capacity solved the issue.

A message at startup  about the lack of temporary space would be helpful.
Comment 8 ar@home 2016-08-07 15:15:21 UTC
(In reply to Frank Steinmetzger from comment #5)
> I see. I replaced ~/.cache/showfoto with a symlink to /var/tmp, which is a
> 24 G ramdisk on this machine. Undo works now, thanks for the hint.
> 
> I think some kind of notification would be helpful for other unsuspecting
> users, though. I saw that log line, too. But I did not think much of it
> because it looks like a statement, rather than an error message.

Here the  shofoto cache already resided on /var/tmp/kdecache-'user'/showFoto which was located on a logical volume that had only 800M left. Putting /var/tmp/ on an LV with 4G capacity solved the issue.

A message at startup  about the lack of temporary space would be helpful.
Comment 9 Maik Qualmann 2018-04-29 06:34:04 UTC
Git commit 9897334755437d8da7cfc4b0cf0a7252ec6788d4 by Maik Qualmann.
Committed on 29/04/2018 at 06:32.
Pushed by mqualmann into branch 'master'.

show message box if free disk space for the undo file is < 2GiB
FIXED-IN: 6.0.0

M  +2    -1    NEWS
M  +31   -6    core/utilities/imageeditor/core/undocache.cpp

https://commits.kde.org/digikam/9897334755437d8da7cfc4b0cf0a7252ec6788d4