Bug 366216 - Dropping into folder popup on KUrlNavigator changes folder
Summary: Dropping into folder popup on KUrlNavigator changes folder
Status: RESOLVED WORKSFORME
Alias: None
Product: frameworks-kio
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.24.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: David Faure
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-28 19:11 UTC by Alex Bikadorov
Modified: 2022-12-29 05:24 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Bikadorov 2016-07-28 19:11:39 UTC
It happens when dropping URLs on a folder in the popup opened by the ">" icons in the URL navigator. The navigator emits the "urlsDropped" signal (correct) but also changes the current URL to the dropped folder path (wrong).

Reproducible: Always

Steps to Reproduce:
1. Find some usage of the KUrlNavigator (except Dolphin), e.g. the "open" dialog in Kate
2. (Change the navigator mode from editable to navigate)
3. Drag some file with the mouse from the file view onto one of the ">" icons in the navigator -> a popup with a list of all subfolders will be shown.
4. Drop the file onto one of the folders

Actual Results:  
The current folder changes to the drop folder.

Expected Results:  
Current folder should not change.

This has nothing to do whether dropping is implemented or if the QDropEvent is accepted or not. I tried connecting the signal and accepting the event it but the folder still changes. 

(Background: I'm working on Krusader. The GIT version uses KUrlNavigators now, I wanted to implement the URL dropping and found the bug this way.)

This does not happen in Dolphin. I guess because it uses the old KDE4 libs and the old signal "urlsDropped(KUrl,QDropEvent*)".
Comment 1 Alex Bikadorov 2016-07-31 13:57:26 UTC
update.

I think I tracked it down: in filewidgets/kurlnavigatormenu.cpp there is a signal emitted for every dropEvent AND  mouseReleaseEvent: two signals for one mouse release.

Question is why the mouseButtonClicked signal is emitted for mouse releases and not mouse clicks.

And my new explanation why this does not happen in Dolphin: the dropEvent signal opens a  popup menu by calling KIO::drop(). This menu catches the mouse release event.
Comment 2 Nate Graham 2018-08-22 20:34:11 UTC
Ping, any word on this?
Comment 3 Justin Zobel 2022-11-29 05:06:29 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 4 Bug Janitor Service 2022-12-14 05:12:50 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 5 Bug Janitor Service 2022-12-29 05:24:34 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!