Bug 366188 - Bad exception handling when the kholidays QML module isn't installed
Summary: Bad exception handling when the kholidays QML module isn't installed
Status: RESOLVED DOWNSTREAM
Alias: None
Product: plasmashell
Classification: Plasma
Component: Digital Clock (show other bugs)
Version: 5.7.2
Platform: Kubuntu Linux
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL: https://s31.postimg.org/q0kdovh8b/Scr...
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-27 22:38 UTC by Simon Quigley
Modified: 2018-10-21 06:00 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Quigley 2016-07-27 22:38:44 UTC
If the appropriate kholidays QML package isn't installed on my system, when I go to use the feature, instead of displaying something like, "The kholidays QML package isn't present on your system," it displays the error on the screenshot.

Ideally the exception handling could be improved.

Reproducible: Always

Steps to Reproduce:
1. Right-click on the digital clock and select Digital Clock Settings.
2. Go to the Holidays tab.

Actual Results:  
The error in the screenshot about the QML module not being installed.

Expected Results:  
It displays an error like, "The kholidays QML module is not installed."

I'm using the Kubuntu Team's Plasma and Apps PPAs.
Comment 1 Kai Uwe Broulik 2016-08-03 12:41:20 UTC
Isn't kholidays a hard dependency of Plasma, Martin?
Comment 2 Martin Klapetek 2016-08-03 22:26:26 UTC
No; the system is a bit more complicated.

Plasma-framework, which has the calendar backend and the events backend, depends on KF5::CalendarEvents, which is part of KDeclarative.

Plasma-workspace then has a plugin based on KHolidays that is being loaded by that Plasma-framework code.

The actual error from the screenshot comes from KHoliday I believe, which has declarative imports that the plugin in Plasma-workspace uses.

I would advise to file a bug against Kubuntu packaging and at the same time add a required version of KHolidays in -workspace, which seems to be missing. On a side note, KHolidays is now in this strange limbo where it is a framework that is being released with applications, so the versioning might be a bit weird.

Finally, Simon, for future reference, please always attach screenshots directly to bugzilla or at least include the text of the error here, so that we know what this is about in case the image is taken down from a 3rd party site.
Comment 3 Martin Klapetek 2016-08-03 22:27:26 UTC
> The actual error from the screenshot comes from KHoliday I believe, which has declarative imports that the plugin in Plasma-workspace uses.

What I forgot to add in this sentence is that the installed KHolidays version is too old, that's the actual problem. I think.
Comment 4 Simon Quigley 2018-10-21 06:00:47 UTC
Going through things, I think this was solved a while ago.