Bug 366138 - configure errors out when using Xcode 8 (clang 8.0.0)
Summary: configure errors out when using Xcode 8 (clang 8.0.0)
Status: RESOLVED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: general (show other bugs)
Version: 3.12 SVN
Platform: MacPorts macOS
: NOR normal
Target Milestone: ---
Assignee: Rhys Kidd
URL:
Keywords:
Depends on:
Blocks: 365327
  Show dependency treegraph
 
Reported: 2016-07-26 16:39 UTC by jeremyhu
Modified: 2016-09-11 13:56 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
configure.ac patch (852 bytes, patch)
2016-07-26 16:45 UTC, jeremyhu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description jeremyhu 2016-07-26 16:39:06 UTC
Using current trunk (valgrind r15915, vex r3232), valgrind is failing to configure when using Xcode 8.

configure:5397: checking for a supported version of gcc
configure:5481: result: no (8.0.0)
configure:5483: error: please use gcc >= 3.0 or clang >= 2.9 or icc >= 13.0

The problem is with:

applellvm-5.1|applellvm-6.*|applellvm-7.*)

and also note that is_clang is not included in the error message.



Reproducible: Always

Steps to Reproduce:
1. Use Xcode 8 to build valgrind


Actual Results:  
configure should have succeeded

Expected Results:  
configure failed

--- configure.ac.orig	2016-07-26 09:30:11.000000000 -0700
+++ configure.ac	2016-07-26 09:30:27.000000000 -0700
@@ -154,7 +154,7 @@ AM_CONDITIONAL(COMPILER_IS_ICC, test $is
 # Note: m4 arguments are quoted with [ and ] so square brackets in shell
 # statements have to be quoted.
 case "${is_clang}-${gcc_version}" in
-     applellvm-5.1|applellvm-6.*|applellvm-7.*)
+     applellvm-5.1|applellvm-[[6-9]].*|applellvm-[[1-9]][[0-9]].*)
 	AC_MSG_RESULT([ok (Apple LLVM version ${gcc_version})])
 	;;
      icc-1[[3-9]].*)
@@ -167,7 +167,7 @@ case "${is_clang}-${gcc_version}" in
 	AC_MSG_RESULT([ok (clang-${gcc_version})])
 	;;
      *)
-	AC_MSG_RESULT([no (${gcc_version})])
+	AC_MSG_RESULT([no (${is_clang}-${gcc_version})])
 	AC_MSG_ERROR([please use gcc >= 3.0 or clang >= 2.9 or icc >= 13.0])
 	;;
 esac
Comment 1 jeremyhu 2016-07-26 16:45:40 UTC
Created attachment 100314 [details]
configure.ac patch
Comment 2 Rhys Kidd 2016-08-10 06:48:13 UTC
Thanks, I'll take a look.

As Xcode 8 remains in pre-release this isn't an urgent fix, although I aim to land this ahead of the next valgrind release. Such a release will hopefully also include initial support of macOS 10.12.
Comment 3 Douglas Pearless 2016-09-11 01:35:56 UTC
i fixed my config script by changing:
applellvm-5.1|applellvm-6.*|applellvm-7.*)
to
applellvm-5.1|applellvm-6.*|applellvm-7.*|applellvm-8.*)
Comment 4 Rhys Kidd 2016-09-11 13:45:17 UTC
Jeremy,
I've split the fix into two. Your patch for an improved configure output message upon compiler version error landed in r15948. Thanks!
Support for Xcode 8's clang compiler will land separately.
Comment 5 Rhys Kidd 2016-09-11 13:56:21 UTC
Xcode 8 support landed in r15949. Xcode 8 has a GM available to download.

This applies to both OS X 10.11 and macOS 10.12; although the later requires further patches to land before Valgrind supports that xnu kernel.