Bug 366030 - Ratio sensor seems to be applied after rotation under some conditions
Summary: Ratio sensor seems to be applied after rotation under some conditions
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Brush engines (show other bugs)
Version: git master (please specify the git hash!)
Platform: Debian unstable Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-24 08:51 UTC by Ilya V. Portnov
Modified: 2016-08-17 08:19 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Here you can see some parallelograms where rectangles are expected to be seen (73.68 KB, image/png)
2016-07-24 08:52 UTC, Ilya V. Portnov
Details
Brush preset which was used for test (4.30 KB, image/png)
2016-07-24 08:53 UTC, Ilya V. Portnov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya V. Portnov 2016-07-24 08:51:47 UTC
For test, i'm using simple brush with "predefined" brush tip, which is just filled square.
The preset is defined so that:
* rotation depends on drawing angle
* ratio depends on "fuzzy stroke".

I think that rotation should be applied after ratio; so, if you take a square, then apply "ratio" = 0.5, then rotate it, you will get a rotated rectangle. 
But if you first rotate the square, and next apply ratio, you will get a parallelogram. I think this is not what intended.

Will attach a screenshot.

Reproducible: Always


Actual Results:  
brush draws series of parallelograms.

Expected Results:  
brush draws series of rotated rectangles.
Comment 1 Ilya V. Portnov 2016-07-24 08:52:43 UTC
Created attachment 100264 [details]
Here you can see some parallelograms where rectangles are expected to be seen
Comment 2 Ilya V. Portnov 2016-07-24 08:53:37 UTC
Created attachment 100265 [details]
Brush preset which was used for test
Comment 3 Halla Rempt 2016-08-12 11:41:06 UTC
I've asked Nishanth to take a look.
Comment 4 Halla Rempt 2016-08-17 08:19:11 UTC
Fixed in 61c422b9ad25cb6291a9a33094331de4b0f9f7c2