If i have mirror view enabled (by pressing M), then the pan tool zips around predictably, and the zoom tools acts as if mirror view was not enabled Reproducible: Always Steps to Reproduce: 1. press M to enable mirror view 2. try to pan with the pan tool, or zoom with the zoom tool
Confirmed here.
Can confirm this happens on Ubuntu 15.10 with Krita master branch (git a8f901e40fb7de35a29a4b4803ccbacab802c8bd).
Is this a regression caused by the relative zoom tool patch?
No, it's too old for that, and it only happens with the zoom/pan TOOLS, not the regular zoom/pan
Ah, then that's probably because the zoom/pan tools actually predate the canvas mirror feature.
Git commit aaaf1eea993d3dc65bcd3585cabf7751464e9567 by Victor Wåhlström. Committed on 20/06/2017 at 19:43. Pushed by victorw into branch 'master'. Rewrote the Pan tool based on KisTool. Fixes pan issues when mirroring is enabled. Differential Revision: https://phabricator.kde.org/D6245 M +0 -2 libs/flake/CMakeLists.txt M +24 -0 libs/flake/KoCanvasController.h M +20 -0 libs/flake/KoCanvasControllerWidget.cpp M +5 -0 libs/flake/KoCanvasControllerWidget.h M +0 -6 libs/flake/KoToolManager.cpp M +0 -3 libs/flake/KoToolRegistry.cpp D +0 -121 libs/flake/tools/KoPanTool.cpp D +0 -73 libs/flake/tools/KoPanTool.h D +0 -40 libs/flake/tools/KoPanToolFactory.cpp D +0 -35 libs/flake/tools/KoPanToolFactory.h M +1 -0 plugins/tools/basictools/CMakeLists.txt M +2 -0 plugins/tools/basictools/default_tools.cc A +100 -0 plugins/tools/basictools/kis_tool_pan.cpp [License: GPL (v2+)] A +54 -0 plugins/tools/basictools/kis_tool_pan.h [License: GPL (v2+)] https://commits.kde.org/krita/aaaf1eea993d3dc65bcd3585cabf7751464e9567
Victor, can we now close this bug?
This is a two-for-one bug, and I only fixed the pan tool version of it. I created bug 386704 to track the zoom tool version of the bug. Unfortunately the same solution cannot be applied to the zoom tool, so it's not as easy. I'll edit the title of this bug so it can be closed. The zoom tool bug should be tracked in bug 386704.