Bug 365923 - Solid udisks2 backend fails to compile on musl libc: dev_t requires sys/types.h
Summary: Solid udisks2 backend fails to compile on musl libc: dev_t requires sys/types.h
Status: RESOLVED FIXED
Alias: None
Product: frameworks-solid
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.24.0
Platform: Compiled Sources Linux
: NOR major
Target Milestone: ---
Assignee: Lukáš Tinkl
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-21 07:48 UTC by A. Wilcox (awilfox)
Modified: 2018-08-30 18:46 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.37.0


Attachments
Add #include <sys/types.h> to udisksblock.h (431 bytes, patch)
2016-07-21 07:48 UTC, A. Wilcox (awilfox)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description A. Wilcox (awilfox) 2016-07-21 07:48:13 UTC
The udisks2 backend of the Solid framework does not #include <sys/types.h>, which causes a compile-time error on the musl libc where dev_t is not defined in other headers.

A patch is included that has solved this issue for us at Adélie Linux.

Reproducible: Always

Steps to Reproduce:
1. Use musl libc.
2. Attempt to build Solid.

Actual Results:  
In file included from /usr/src/kde-frameworks/solid-5.21.0/work/solid-5.21.0/src/solid/devices/backends/udisks2/udisksdevice.cpp:24:0:
/usr/src/kde-frameworks/solid-5.21.0/work/solid-5.21.0/src/solid/devices/backends/udisks2/udisksblock.h:48:5: error: ‘dev_t’ does not name a type
     dev_t m_devNum;
     ^

Expected Results:  
A successful build.
Comment 1 A. Wilcox (awilfox) 2016-07-21 07:48:48 UTC
Created attachment 100224 [details]
Add #include <sys/types.h> to udisksblock.h