Bug 365792 - Folder View widget cannot show hidden files, filters hide everything
Summary: Folder View widget cannot show hidden files, filters hide everything
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Folder (show other bugs)
Version: 5.5.5
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-17 18:57 UTC by Michael
Modified: 2022-11-21 15:36 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.27


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael 2016-07-17 18:57:05 UTC
The Folder View widget in my panel won't show hidden files.  There does not seem to be an explicit option to show them (I had such an option in the QuickAccess widget using Plasma 4).  When I tried to use the Filter feature, it would hide everything.

Reproducible: Always

Steps to Reproduce:
1. Add a Folder View widget to your panel, go to its Settings.
2. Specify a folder which contains hidden files or folders.
3. Note how there is no setting for showing hidden files/folders.
4. Go to the Filter section, select the "Show Files Matching" option, then set the pattern to this: .*
6. Hit OK.
7. Click on the Folder View widget's icon in the panel to open the listing.  No hidden files are shown.  In fact no contents are shown at all.
8. Go back to the Filter section of the settings and change the pattern to * and select all of the file types.  Hit OK.
9. Repeat step 7 -- still nothing.

Actual Results:  
When using the filters, no files/directories were shown.

Expected Results:  
Even if there is some hidden feature/bug which is hiding hidden files, I would still expect non-hidden files matching the pattern to be shown.  Instead nothing was shown at all.  I also do expect there to be a setting or some way to get hidden files to be shown.
Comment 1 Michael 2016-07-17 19:04:41 UTC
Also, not to be pedantic, but the option under Filter does say "Show All Files" and that is clearly not what is happening.  It should say "Show All Visible Files" or "Show All Non-Hidden Files".

If an option were to be added to show hidden files, it would probably be okay to leave the filter option called "Show All Files" since the presence of an option for hidden files would imply that "All" does not actually mean all.
Comment 2 Eike Hein 2016-07-18 10:49:53 UTC
> Even if there is some hidden feature/bug which is hiding hidden files, I would still expect non-hidden files matching the pattern to be shown. 

How can there be non-hidden files matching .*? (It's not regex.)
Comment 3 Michael 2016-07-18 13:00:26 UTC
Yes I know, but my point is that it didn't even show hidden files.  And even if you set the filter to *, which should match all non-hidden files, nothing is shown.
Comment 4 Eike Hein 2016-07-24 17:54:57 UTC
Git commit f93e46bbb7849907c647f7e7dfc59c7fd3e3d09d by Eike Hein.
Committed on 24/07/2016 at 17:54.
Pushed by hein into branch 'Plasma/5.7'.

Fix changes of the filter pattern not being applied immediately.

Adds missing invalidateFilter call to prop setter.

M  +2    -0    containments/desktop/plugins/folder/foldermodel.cpp

http://commits.kde.org/plasma-desktop/f93e46bbb7849907c647f7e7dfc59c7fd3e3d09d
Comment 5 Alexander Mentyu 2017-12-13 17:16:11 UTC
in '.*' pattern - no files/folders are displayed,
in '*' pattern - all files/folders are displayed as in 'Show All Files' selection:


Distribution: KDE neon Developer Edition - Unstable Branches
Plasma: 5.11.90
Frameworks: 5.42.0
Qt: 5.9.3
Kernel 4.10.0-42-generic


Netrunner Rolling
Plasma: 5.11.4
Apps: 17.08.3
Frameworks: 5.40.0
Qt: 5.9.3
Kernel: 4.14.3-1-MANJARO
Comment 6 Nate Graham 2020-01-23 18:47:22 UTC
Still reproducible in git master.
Comment 7 Willyanto 2021-03-02 16:21:45 UTC
The reason why '*' pattern shows nothing is because "Show Matching" option checks for file/folder name and selected type(s) in the checkbox. By default, none of the type options are checked. This causes nothing to be shown as every files/folders are not matching the selected type(s) despite matching name. For example if the pattern is '*' and the option "inode/directory" is checked, then it will show every non-hidden folders because every folders match the pattern and the selected type(s).
Comment 8 Bug Janitor Service 2021-03-08 13:16:48 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/375
Comment 9 Nate Graham 2022-11-21 15:36:55 UTC
Git commit 244d9bec60b218f9a721bf18fa7ebc577da3c5dd by Nate Graham, on behalf of Willyanto Willyanto.
Committed on 21/11/2022 at 15:36.
Pushed by ngraham into branch 'master'.

Folder View: Add option to show hidden files
FIXED-IN: 5.27

M  +4    -0    containments/desktop/package/contents/config/main.xml
M  +6    -0    containments/desktop/package/contents/ui/ConfigFilter.qml
M  +1    -0    containments/desktop/package/contents/ui/FolderView.qml
M  +1    -0    containments/desktop/package/contents/ui/FolderViewLayer.qml
M  +25   -2    containments/desktop/plugins/folder/autotests/foldermodeltest.cpp
M  +1    -0    containments/desktop/plugins/folder/autotests/foldermodeltest.h
M  +17   -0    containments/desktop/plugins/folder/foldermodel.cpp
M  +6    -0    containments/desktop/plugins/folder/foldermodel.h

https://invent.kde.org/plasma/plasma-desktop/commit/244d9bec60b218f9a721bf18fa7ebc577da3c5dd