Bug 365740 - Regression: player controls no longer show for amarok
Summary: Regression: player controls no longer show for amarok
Status: RESOLVED DUPLICATE of bug 365275
Alias: None
Product: plasmashell
Classification: Unclassified
Component: Icons-only Task Manager (show other bugs)
Version: 5.7.1
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-16 11:05 UTC by Christian (Fuchs)
Modified: 2016-07-17 12:05 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian (Fuchs) 2016-07-16 11:05:52 UTC
Since the 5.7.1 update I no longer have player controls in the tooltip of the amarok task. 

The controls are available in the media player control plasmoid (that you can place in the systray), so mpris and amarok seem to work. Other applications, such as smplayer, work as expected.

Reproducible: Always

Steps to Reproduce:
1. Update to the lastest plasma
2. Have an amarok entry in the icons only task manager
3. Run amarok
4. Mouse hover

Actual Results:  
Player controls are missing

Expected Results:  
Player controls are there

Frameworks is 5.24, amarok is 2.8.90
Comment 1 Eike Hein 2016-07-17 07:23:21 UTC
That's due to Amarok's .desktop file being misnamed and was fixed upstream recently.

*** This bug has been marked as a duplicate of bug 365275 ***
Comment 2 Christian (Fuchs) 2016-07-17 11:36:57 UTC
Do you happen to have a commit link so I can fix it locally? I can't find that on amarok's gitweb. 

Also: as it worked in 5.7.0 and stopped in 5.7.1, I propose that the old, working method is used until there is an amarok release containing that fix.
Comment 3 Kai Uwe Broulik 2016-07-17 11:46:04 UTC
The commit that changed this behavior is [1] which was in *before* the 5.7.0 final release, so this is not a regression that occured in 5.7.1.

The previous method used by just using the DBus service name was insufficient and wrong and worked purely by chance with Amarok but did not with eg. Dragon Player, Nuvola, and others. The new approach is correct by asking the application what its desktop file name is and if Amarok lies to us this is solely Amarok's fault.

[1] https://quickgit.kde.org/?p=plasma-desktop.git&a=commit&h=0d6442d8374f87880de2aad044cd1563ed6fde75
Comment 4 Christian (Fuchs) 2016-07-17 11:58:49 UTC
(In reply to Kai Uwe Broulik from comment #3)
> The commit that changed this behavior is [1] which was in *before* the 5.7.0
> final release, so this is not a regression that occured in 5.7.1.

Odd, because it worked for me in 5.7.0 and only broke after updating to 5.7.1. I shall assume packaging, then.

> The previous method used by just using the DBus service name was
> insufficient and wrong and worked purely by chance with Amarok but did not
> with eg. Dragon Player, Nuvola, and others. The new approach is correct by
> asking the application what its desktop file name is and if Amarok lies to
> us this is solely Amarok's fault.

End users simply won't care whose fault it is. It worked, it no longer works, they see the error in plasma. So at least a workaround would be nice, because fixing it does not only require it being commited to amarok (which, as far as I can see, didn't happen yet) but also someone making a release out of that and it ending up with packagers. That might take a while, given amarok activity, and in the meantime it stays broken for users.

As a minor sidenote: as I wrote it works in the media player control plasmoid, so either that one uses what you consider a wrong method to, or it has a way which would not break it, maybe that's worth being investigated.

> [1]
> https://quickgit.kde.org/?p=plasma-desktop.
> git&a=commit&h=0d6442d8374f87880de2aad044cd1563ed6fde75
Comment 5 Christian (Fuchs) 2016-07-17 12:01:59 UTC
Thinking of it, probably the applet only works because it doesn't have to do a match between application and dbus, so that one is not an option. Ignore that part, rest still valid.
Comment 6 Kai Uwe Broulik 2016-07-17 12:05:45 UTC
I agree this isn't optimal but this has been wrong in Amarok for years... in Media Controller it works because it doesn't need to map windows to mpris services. You surely don't want media controls for the currently running player on all tooltips.

Also, owing to the lack of reactions on this review request [1], there doesn't seem to be any interest in fixing this from Amarok's side. Sorry.

[1] https://git.reviewboard.kde.org/r/128418/