All Layer Translformation actions (see atachment) should work in a universal way, that is: 1) If there is a selection present, process the current selection on the currently selected layer 2) If there is no selection, just process the whole layer bounds 3) It might be a good idea to have some shortcuts for mirroring and rotation actions 4) They also should be renamed to conform with the new behavior See bug 352533 as an initial idea. WISHGROUP: Small Usability Fixes
Created attachment 100056 [details] List of affected actions
*** Bug 362989 has been marked as a duplicate of this bug. ***
Git commit 3014d62c9817690ed21384450cb771c75bf60ce4 by Dmitry Kazakov. Committed on 09/09/2018 at 13:52. Pushed by dkazakov into branch 'master'. Now Rotate/Scale/Mirror/Shear Layer actions also support handling a selection. If there is a selection active, then the action will transform selected content only. Now there are also 8 new actions, that will rotate/scale/ mirror/shear *all* layers without resizing the image. These actions can also handle selections. Animation Note: * when no selection present, the actions transform *all* the frames of the layers in question * when there is a selection active, only current frame is transformed Ref T3920 CC:kimageshop@kde.org M +96 -0 krita/krita.action M +15 -0 krita/krita4.xmlgui M +2 -0 libs/image/CMakeLists.txt R +0 -0 libs/image/commands_new/kis_transaction_based_command.cpp [from: libs/ui/kis_transaction_based_command.cpp - 100% similarity] R +2 -2 libs/image/commands_new/kis_transaction_based_command.h [from: libs/ui/kis_transaction_based_command.h - 092% similarity] M +79 -27 libs/image/kis_image.cc M +6 -7 libs/image/kis_image.h M +12 -0 libs/image/kis_processing_applicator.cpp M +5 -0 libs/image/kis_processing_visitor.cpp M +8 -0 libs/image/kis_processing_visitor.h A +91 -0 libs/image/processing/KisSelectionBasedProcessingHelper.cpp [License: UNKNOWN] * A +37 -0 libs/image/processing/KisSelectionBasedProcessingHelper.h [License: UNKNOWN] * M +26 -9 libs/image/processing/kis_mirror_processing_visitor.cpp M +10 -0 libs/image/processing/kis_mirror_processing_visitor.h M +37 -5 libs/image/processing/kis_transform_processing_visitor.cpp M +8 -1 libs/image/processing/kis_transform_processing_visitor.h M +11 -4 libs/libkis/Node.cpp M +1 -1 libs/libkis/Node.h M +0 -1 libs/ui/CMakeLists.txt M +1 -1 libs/ui/actions/kis_selection_action_factories.cpp M +42 -56 libs/ui/kis_node_manager.cpp M +7 -12 libs/ui/kis_node_manager.h M +1 -1 libs/ui/operations/kis_filter_selection_operation.cpp M +0 -104 libs/ui/tests/kis_node_manager_test.cpp M +0 -6 libs/ui/tests/kis_node_manager_test.h M +1 -1 libs/ui/tool/kis_selection_tool_helper.cpp M +1 -1 plugins/dockers/gamutmask/gamutmask_dock.cpp M +46 -14 plugins/extensions/imagesize/imagesize.cc M +6 -0 plugins/extensions/imagesize/imagesize.h M +1 -1 plugins/extensions/pykrita/sip/krita/Node.sip M +91 -10 plugins/extensions/rotateimage/rotateimage.cc M +12 -0 plugins/extensions/rotateimage/rotateimage.h M +25 -4 plugins/extensions/shearimage/shearimage.cc M +6 -0 plugins/extensions/shearimage/shearimage.h M +1 -1 plugins/tools/tool_smart_patch/kis_tool_smart_patch.cpp The files marked with a * at the end have a non valid license. Please read: https://community.kde.org/Policies/Licensing_Policy and use the headers which are listed at that page. https://commits.kde.org/krita/3014d62c9817690ed21384450cb771c75bf60ce4