Bug 365572 - Use kdialog for selecting save location
Summary: Use kdialog for selecting save location
Status: RESOLVED FIXED
Alias: None
Product: Spectacle
Classification: Applications
Component: General (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Boudhayan Gupta
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-12 22:01 UTC by Janek Bevendorff
Modified: 2016-10-13 23:31 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Janek Bevendorff 2016-07-12 22:01:40 UTC 
Spectacle uses the built-in Qt file picker instead of the one provided by the system (i.e. kdialog). It's missing a lot of features, is therefore cumbersome to use and doesn't integrate well with the rest of the desktop. As part of the KDE family, Spectacle should really use the provided platform tools.

Reproducible: Always
Comment 1 Boudhayan Gupta 2016-07-13 06:10:25 UTC 
This is an intentional change. I'm waiting for a bugfix in KDialog's filter-by-file-type.
Comment 2 Janek Bevendorff 2016-07-13 09:59:22 UTC 
What filter bug are you talking about? Bug 319502? That's the only bug
report I can find about filters and I'm not even sure if that's really a
kdialog bug or rather a PyQt4 bug (and in PyQt5 there isn't even a
method QFileDialog.getOpenFileNameAndFilter()).

The file dialog used by Spectacle is just utterly useless. It doesn't
even show file/folder icons which makes it really hard to tell files and
folders apart. All my bookmarks etc. are also missing. It's about as
ugly and hard to use the the GtkFileChooserDialog (which IMHO is one of
the ugliest pices of any GUI framework ever produced).

I'm not quite sure what filter bug you mean, but I would glady accept
some issues with file filters in exchange for a proper file dialog.
Comment 3 Christoph Feck 2016-07-18 20:39:09 UTC 
Janek, see bug 357865.
Comment 4 Christoph Feck 2016-10-13 23:31:35 UTC 
See bug 369174 for the commit details.