Bug 365445 - Improve timeline track controllers
Summary: Improve timeline track controllers
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface (show other bugs)
Version: 16.04.0
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-11 23:14 UTC by farid
Modified: 2016-07-25 00:04 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Normal track height with controllers (448.79 KB, image/jpeg)
2016-07-11 23:15 UTC, farid
Details
Minimum track height without controllers (470.63 KB, image/jpeg)
2016-07-11 23:15 UTC, farid
Details
Minimum track height WITH controllers (474.35 KB, image/jpeg)
2016-07-11 23:16 UTC, farid
Details

Note You need to log in before you can comment on or make changes to this bug.
Description farid 2016-07-11 23:14:38 UTC
When tracks are minimized to the max, the track controllers disappear making the workflow really hard whenever you want to enable disable a video/audio of a track.



Reproducible: Always


Actual Results:  
The controllers disappear when tracks are minimized to the fullest.

Expected Results:  
The controllers should appear. Look at mockup in the attachment.
Comment 1 farid 2016-07-11 23:15:13 UTC
Created attachment 100024 [details]
Normal track height with controllers
Comment 2 farid 2016-07-11 23:15:51 UTC
Created attachment 100025 [details]
Minimum track height without controllers
Comment 3 farid 2016-07-11 23:16:47 UTC
Created attachment 100026 [details]
Minimum track height WITH controllers

I made this mockup to show how it should appear.
Comment 4 Jean-Baptiste Mardelle 2016-07-13 10:57:48 UTC
Git commit 44e0ed6ba35decede03a969ac463ea71b9894705 by Jean-Baptiste Mardelle.
Committed on 13/07/2016 at 10:57.
Pushed by mardelle into branch 'master'.

Show track buttons even on smaller track sizes

M  +1    -0    src/timeline/customruler.cpp
M  +1    -0    src/timeline/customtrackview.cpp
M  +19   -5    src/timeline/headertrack.cpp
M  +2    -2    src/timeline/timeline.cpp
M  +134  -104  src/ui/timeline_ui.ui
M  +15   -10   src/ui/trackheader_ui.ui

http://commits.kde.org/kdenlive/44e0ed6ba35decede03a969ac463ea71b9894705
Comment 5 Wegwerf 2016-07-13 17:21:08 UTC
Hmm ... only works half on my system: while the controllers are mostly kept, some of them still vanish. Also, since the track header width it simply too narrow, I only see one or two title letters, then the lock icon, then the mute icon, ... then something that looks like an overflow-menu icon ">" that doesn't work at all. So the video and composite controls are missing. For the bottommost track, there is no composite control, so lock, mute, hide video all fit into the space.

My personal impression is that making the track headers resizeable would not only solve this problem, but also the issue of narrow track headers in general. Users then could adapt the Kdenlive track header width to their particular display and project setup.
Comment 6 Jean-Baptiste Mardelle 2016-07-13 18:13:48 UTC
With my latest patch, the header width is resizable. You can drag the right border to make it larger. The ">" icon works for me if tracks are too narrow, but you should anyways be able to resize to show all icons...
Comment 7 Wegwerf 2016-07-13 18:39:42 UTC
Oops, didn't notice that the tracks headers are now realizable. Works soo great, thank you very much!

The overflow button doesn't work for me at the first click. I have to click again so it deselects. Then clicking once more it now displays the overflow menu. Afterwards, the ">" works as expected. The same happens for all track headers: at first, the ">" doesn't work, click, click, and now they start working.

Did I say THANK YOU for resizable track headers? THANK YOU!
Comment 8 Wegwerf 2016-07-13 19:01:52 UTC
Only a minor nitpick: track header width is not made persistent (either in project or for Kdenlive itself). Would it be possible to at least store it as part of Kdenlive's UI configuration?
Comment 9 Wegwerf 2016-07-14 07:57:25 UTC
Jean-Baptiste, thank you for adding persistence of the set video track header width across sessions! This is sweet.
Comment 10 farid 2016-07-25 00:04:17 UTC
thanks jb.