Bug 365324 - Fatal flaws in the Dynamic Brush engine!
Summary: Fatal flaws in the Dynamic Brush engine!
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Brush engines (other bugs)
Version First Reported In: 3.0
Platform: Other Microsoft Windows
: NOR crash
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-10 16:29 UTC by matan.face
Modified: 2016-08-25 12:06 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description matan.face 2016-07-10 16:29:07 UTC
I found a fatal flaws in the dynamic brush engine!

If you insert a negative value into the "Mass" variable in the dynamic brush engine (it's at the dynamic settings tab) it will make a brush stroke that will continue happening for eternity and will never stop! you are basically forced to stop the loading of the brush or you wont be able to draw anything.

It also does an infinite line when you put the "Drag" variable in the "Dynamic settings tab" to very high values! (like 49.0 or 50.0 for example)
Krita actually crushed for me because of this! it did not even let me stop the brush process!

---
Another improvements that should be made to the Dynamic Brush engine btw:
1. Put sliders to determine the variables in the "dynamic settings" tab, so that variables can be changed more quickly without inputting numbers
2. The size of the brush should be determined by the normal way brush sizes are determined, not with just with the "Diameter" variable 
3. The diameter variable only changes the size of the brush when you use "circle" in the shape tab, but doesn't change the size of it in all the other options!
4. obscure variables: the lines option in the "shape" tab has two variables, and you can see their name only when holding the mouse above them, and the circle option has a checkbox with the word "two", which is rather obscure.)
---
Comment 1 Halla Rempt 2016-08-25 12:06:32 UTC
Git commit 9fb7eda716fd82dea825e44d3b5a0dee1aa19e8b by Boudewijn Rempt.
Committed on 25/08/2016 at 12:06.
Pushed by rempt into branch 'master'.

M  +19   -10   plugins/paintops/dynadraw/wdgdynaoptions.ui

http://commits.kde.org/krita/9fb7eda716fd82dea825e44d3b5a0dee1aa19e8b