The information on Japanese holidays is outdated. Updated holiday data files are attached. For holidays whose date varies, I have included them from 2010 through 2019, but can add more if needed. Reproducible: Always Steps to Reproduce: 1. Consult the calendar for example by clicking the Digital Clock widget. Actual Results: For holidays whose date varies, some dates are incorrect. Greenery Day is still on April 29, even though it was moved to May 4 and replaced by Showa Day. Mountains' Day is missing. Expected Results: Holiday names and dates should be correct.
Created attachment 99948 [details] Update Japanese holiday data file (Japanese language)
Created attachment 99949 [details] Update Japanese holiday data file (English language)
Thanks for the update. When were these changes decided ? it may be worth keeping 29 april for the previous years.
April 29 is the birthday of Emperor Showa; during his reign (until 1988) it was the Emperor's Birthday holiday. In 1989 it was renamed to Greenery Day, and in 2007 to Showa Day. Greenery Day was then moved to May 4, which previously was a "citizens' holiday". Mountains' Day was introduced in 2016.
Git commit 49f6abb6035f97c0a98113e3aedf5d2db135bf63 by Allen Winter. Committed on 03/06/2018 at 17:53. Pushed by winterz into branch 'master'. updated Japanese holidays (in Japanese and English) FIXED-IN: 5.48.0 M +39 -96 holidays/plan2/holiday_jp_en-us M +45 -101 holidays/plan2/holiday_jp_ja https://commits.kde.org/kholidays/49f6abb6035f97c0a98113e3aedf5d2db135bf63
FYI: I removed the equinox holidays because KHolidays now computes the equinoxes and solstices automatically and adds them to holidays. if the equinoxes in Japan need to be different than the computed values let me know.
Hey Allen, did you read diff ( https://cgit.kde.org/kholidays.git/commit/?id=49f6abb6035f97c0a98113e3aedf5d2db135bf63 ) when you merge the attached files? The code attached by Firas is based on quite old codebase (July 2016) and it reverts my updates done in May 2017: https://phabricator.kde.org/D5736 https://cgit.kde.org/kholidays.git/commit/?id=f6044686a1768565bcf3d91489f1b080d64c8666 It removes metadata, re-add non-existing holidays (The days listed in "Cultural" section including St. Valentine's Day, Girls' Festival, and Buddha's Birthday are not holidays in Japan), removes comments referring governmental information about holidays. I think your commit 49f6abb should be reverted. I opened request to revert 49f6abb: https://phabricator.kde.org/D13812
As I commented in Phabricator, Japanese Equinox Days cannot be calculated automatically. Therefore, I think equinox days should be kept. https://phabricator.kde.org/D13812
Git commit 1c2ecfbf9570752d516f204d3034cc714e3ff66f by Allen Winter. Committed on 08/07/2018 at 16:06. Pushed by winterz into branch 'master'. holiday_jp_ja, holiday_jp-en_us - updated Thanks for the patch phanect Differential Revision: https://phabricator.kde.org/D13812 M +96 -39 holidays/plan2/holiday_jp_en-us M +96 -47 holidays/plan2/holiday_jp_ja https://commits.kde.org/kholidays/1c2ecfbf9570752d516f204d3034cc714e3ff66f