Bug 365120 - Range in Outer Glow Layer Style Value 0 Causes Crash
Summary: Range in Outer Glow Layer Style Value 0 Causes Crash
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: layer styles (show other bugs)
Version: 3.0
Platform: Microsoft Windows Microsoft Windows
: NOR crash
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-05 19:37 UTC by Erekose Craft
Modified: 2016-08-15 10:39 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screenshot of the crash and values set in layer styles (190.36 KB, image/png)
2016-07-05 19:37 UTC, Erekose Craft
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Erekose Craft 2016-07-05 19:37:13 UTC
Created attachment 99867 [details]
Screenshot of the crash and values set in layer styles

In the Layer Styles menu, under Outer Glow, when setting the Range value to 0, Krita crashes.
More so, the Range option doesn't work as expected.

Expected behavior:
Altering the range value should change the contour falloff start for the glow, with values ranging from 100% to 1% (Photoshop ends at 1%)

Actual behavior:
Altering the range value causes odd jittering similar to several hard aliased lines tracing loops in the Outer Glow. The value can be set to 0%, at which point Krita crashes.

OS: Windows 10
Krita Version: 3.0
GPU: Nvidia 555M
CPU: Intel i5- 2520M
Comment 1 Halla Rempt 2016-07-06 08:18:33 UTC
Hi,

Thanks for your report. I can confirm the crash. I will have to ask Dmitry to look at the actual behaviour of the range option, though.
Comment 2 Halla Rempt 2016-07-06 08:39:01 UTC
Git commit 31746ee12ae60a2a8b248ca93b789799beb2bff2 by Boudewijn Rempt.
Committed on 06/07/2016 at 08:38.
Pushed by rempt into branch 'krita/3.0'.
Related: bug 1, bug 100

M  +1    -1    libs/ui/dialogs/kis_dlg_layer_style.cpp

http://commits.kde.org/krita/31746ee12ae60a2a8b248ca93b789799beb2bff2
Comment 3 Dmitry Kazakov 2016-08-15 10:39:26 UTC
Git commit b8c76c425fdf639ed5a6493d91a27a75f8a3097c by Dmitry Kazakov.
Committed on 15/08/2016 at 10:39.
Pushed by dkazakov into branch 'master'.

Fix one more range slider not to become 0

Boud's fix was absolutely correct. This is just an addition.

Fixes T3177

M  +1    -1    libs/ui/dialogs/kis_dlg_layer_style.cpp

http://commits.kde.org/krita/b8c76c425fdf639ed5a6493d91a27a75f8a3097c