Bug 365000 - Increase list item padding
Summary: Increase list item padding
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Android Android 5.x
: NOR wishlist
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-02 10:55 UTC by Philipp Stefan
Modified: 2016-07-19 12:33 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Stefan 2016-07-02 10:55:10 UTC 
Currently the list items are a bit small on my phone screen. About 0.6cm. I suggest to up the padding on list items (and drawer items) so they reach about 1cm in the real world.

Reproducible: Always
Comment 1 Thomas Pfeiffer 2016-07-19 11:44:28 UTC 
I just compared: The standard height for _menu items_ on Android seems to be 0.8cm, our lists are about 0.7cm on my device.
However, the standard height of _list items_ in Material Design is much higher (72dp).

I'm... not sure. Maybe making the list items ~150% of their current height is a good compromise.

Marco, anything fundamentally speaking against this?
Comment 2 Marco Martin 2016-07-19 11:57:07 UTC 
i would then need to give a different height on desktop where items shouldn't be that tall at all
Comment 3 Marco Martin 2016-07-19 12:33:27 UTC 
now list items on mobile are taller than on desktop