Bug 364998 - Shadow of drawer buttons obstructs its symbol
Summary: Shadow of drawer buttons obstructs its symbol
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Android Android 5.x
: NOR normal
Target Milestone: Not decided
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-02 10:29 UTC by Philipp Stefan
Modified: 2016-07-19 11:29 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Stefan 2016-07-02 10:29:43 UTC
Currently the shadow for the buttons that reveal the drawers come from the middle of the button itself, making the button symbol look muddled and decreases contrast drastically.
The shadow should only be shown on the outline of the button itself and only from one direction.

Reproducible: Always
Comment 1 Thomas Pfeiffer 2016-07-19 10:08:40 UTC
I agree with Philipp, it does look muddled.
Comment 2 Marco Martin 2016-07-19 11:29:24 UTC
Git commit bf7acfb5e572bd55e5c95bf45499ad314dcdc79a by Marco Martin.
Committed on 19/07/2016 at 11:29.
Pushed by mart into branch 'master'.

don't paint shadow behind handle

don't use a dropshadow effect, as it would paint
the shadow visible behind the handle itself, but with layering
hide a black rectangle that is casting a blur, which will
be the only thing visible

M  +27   -16   src/controls/OverlayDrawer.qml

http://commits.kde.org/kirigami/bf7acfb5e572bd55e5c95bf45499ad314dcdc79a