Bug 364928 - kwin-5.6.95 fails to build with kwayland-5.22.0
Summary: kwin-5.6.95 fails to build with kwayland-5.22.0
Status: RESOLVED NOT A BUG
Alias: None
Product: kwin
Classification: Plasma
Component: general (show other bugs)
Version: 5.6.95
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-30 13:06 UTC by Alexander Potashev
Modified: 2016-07-01 05:55 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Potashev 2016-06-30 13:06:46 UTC
kwin-5.6.95 fails to build with kwayland-5.22.0.

Build log:
===
/var/tmp/portage/kde-plasma/kwin-5.6.95/work/kwin-5.6.95/input.cpp:1024:34: error: ‘touchDownRequested’ is not a member of ‘KWayland::Server::FakeInputDevice’
                 connect(device, &FakeInputDevice::touchDownRequested, this,
                                  ^
/var/tmp/portage/kde-plasma/kwin-5.6.95/work/kwin-5.6.95/input.cpp:1030:34: error: ‘touchMotionRequested’ is not a member of ‘KWayland::Server::FakeInputDevice’
                 connect(device, &FakeInputDevice::touchMotionRequested, this,
                                  ^
/var/tmp/portage/kde-plasma/kwin-5.6.95/work/kwin-5.6.95/input.cpp:1036:34: error: ‘touchUpRequested’ is not a member of ‘KWayland::Server::FakeInputDevice’
                 connect(device, &FakeInputDevice::touchUpRequested, this,
                                  ^
/var/tmp/portage/kde-plasma/kwin-5.6.95/work/kwin-5.6.95/input.cpp:1042:34: error: ‘touchCancelRequested’ is not a member of ‘KWayland::Server::FakeInputDevice’
                 connect(device, &FakeInputDevice::touchCancelRequested, this,
                                  ^
/var/tmp/portage/kde-plasma/kwin-5.6.95/work/kwin-5.6.95/input.cpp:1047:34: error: ‘touchFrameRequested’ is not a member of ‘KWayland::Server::FakeInputDevice’
                 connect(device, &FakeInputDevice::touchFrameRequested, this,
                                  ^
===

kwin/CMakeLists.txt contains "find_package(KF5Wayland CONFIG REQUIRED)", but this line does not specify minimum required version which should be at least 5.23.0.

Reproducible: Always
Comment 2 Alexander Potashev 2016-06-30 21:42:25 UTC
(In reply to Martin Gräßlin from comment #1)
> see
> https://quickgit.kde.org/?p=kwin.
> git&a=commit&h=bf2241e78e04fe3f4f877f29e8d17e9829c35a86

That does not fix the problem because the variable KF5_MIN_VERSION is not used in "find_package(KF5Wayland CONFIG REQUIRED)".
Comment 3 Martin Flöser 2016-07-01 05:52:40 UTC
Frameworks are one product. Frameworks do not support version mixing. KWin correctly specifies the dependency to frameworks 5.23 for all frameworks except KWayland. Given that frameworks don't support version mixing, there is nothing wrong from KWin side. This makes this bug report invalid and won't be changed for the Plasma 5.7 release.

For master I'm going to move the finding of KWayland to the other framework sections.
Comment 4 Martin Flöser 2016-07-01 05:55:35 UTC
Git commit d9d70cbaafc929d68c96ac088f2e8df0fa4ba6a3 by Martin Gräßlin.
Committed on 01/07/2016 at 05:54.
Pushed by graesslin into branch 'master'.

Find KF5Wayland together with other frameworks

M  +1    -4    CMakeLists.txt

http://commits.kde.org/kwin/d9d70cbaafc929d68c96ac088f2e8df0fa4ba6a3